Add check for renderer client id.

content/browser/renderer_host/offscreen_canvas_provider_impl.cc

Index: content/browser/renderer_host/offscreen_canvas_provider_impl.cc
diff --git a/content/browser/renderer_host/offscreen_canvas_provider_impl.cc b/content/browser/renderer_host/offscreen_canvas_provider_impl.cc
index 9d578ada2b519faf90d8e4ee2fddee75b94e9e80..65e05c1c502159399503067c5f6dc783e2e3a7f2 100644
--- a/content/browser/renderer_host/offscreen_canvas_provider_impl.cc
+++ b/content/browser/renderer_host/offscreen_canvas_provider_impl.cc
@@ -10,7 +10,9 @@
 
 namespace content {
 
-OffscreenCanvasProviderImpl::OffscreenCanvasProviderImpl() = default;
+OffscreenCanvasProviderImpl::OffscreenCanvasProviderImpl(
+    uint32_t renderer_client_id)
+    : renderer_client_id_(renderer_client_id) {}
 
 OffscreenCanvasProviderImpl::~OffscreenCanvasProviderImpl() = default;
 
@@ -24,6 +26,10 @@ void OffscreenCanvasProviderImpl::CreateOffscreenCanvasSurface(
     const cc::FrameSinkId& frame_sink_id,
     cc::mojom::FrameSinkManagerClientPtr client,
     blink::mojom::OffscreenCanvasSurfaceRequest request) {
+  // TODO(kylechar): Kill the renderer instead of crashing chrome.
+  CHECK_EQ(parent_frame_sink_id.client_id(), renderer_client_id_);
+  CHECK_EQ(frame_sink_id.client_id(), renderer_client_id_);

[piman, 2017/04/12 22:53:37]

Can we just return early / do nothing (and DLOG etc.)?
It will mess up the renderer, but it's the one asking for trouble :)

[kylechar, 2017/04/13 17:09:18]

Done.

+
   OffscreenCanvasSurfaceImpl::Create(parent_frame_sink_id, frame_sink_id,
                                      std::move(client), std::move(request));
 }
@@ -32,6 +38,9 @@ void OffscreenCanvasProviderImpl::CreateCompositorFrameSink(
     const cc::FrameSinkId& frame_sink_id,
     cc::mojom::MojoCompositorFrameSinkClientPtr client,
     cc::mojom::MojoCompositorFrameSinkRequest request) {
+  // TODO(kylechar): Kill the renderer instead of crashing chrome.
+  CHECK_EQ(frame_sink_id.client_id(), renderer_client_id_);

[piman, 2017/04/12 22:53:37]

ditto.

[kylechar, 2017/04/13 17:09:18]

Done.

+
   // TODO(kylechar): Add test for bad |frame_sink_id|.
   auto* manager = OffscreenCanvasCompositorFrameSinkManager::GetInstance();
   auto* surface_impl = manager->GetSurfaceInstance(frame_sink_id);