Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/debugger.dart

Issue 2811343002: Dev compiler debugger related tweaks. (Closed)
Patch Set: Dev compiler debugger related tweaks. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dev_compiler/tool/input_sdk/private/debugger.dart
diff --git a/pkg/dev_compiler/tool/input_sdk/private/debugger.dart b/pkg/dev_compiler/tool/input_sdk/private/debugger.dart
index c4c65a09b3a1935cf806926e465dab5374ceb8e2..da80b3e3f73861248a566903d424942a584df864 100644
--- a/pkg/dev_compiler/tool/input_sdk/private/debugger.dart
+++ b/pkg/dev_compiler/tool/input_sdk/private/debugger.dart
@@ -325,11 +325,17 @@ class JsonMLElement {
/// of properties.
bool isNativeJavaScriptObject(object) {
var type = _typeof(object);
+ if (type != 'object' && type != 'function') return true;
+
+ // Consider all regular JS objects that do not represent Dart modules native
+ // JavaScript objects.
+ if (dart.isJsInterop(object) && dart.getModuleName(object) == null) {
+ return true;
+ }
+
// Treat Node objects as a native JavaScript type as the regular DOM render
// in devtools is superior to the dart specific view.
- return (type != 'object' && type != 'function') ||
- dart.isJsInterop(object) ||
- object is html.Node;
+ return object is html.Node;
}
/// Class implementing the Devtools Formatter API described by:

Powered by Google App Engine
This is Rietveld 408576698