Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: pkg/dev_compiler/lib/src/compiler/compiler.dart

Issue 2811343002: Dev compiler debugger related tweaks. (Closed)
Patch Set: Dev compiler debugger related tweaks. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dev_compiler/lib/src/compiler/compiler.dart
diff --git a/pkg/dev_compiler/lib/src/compiler/compiler.dart b/pkg/dev_compiler/lib/src/compiler/compiler.dart
index e90d37259c18e5796344975881da371aebaac522..d44bc16b2396eaab01a9c2d0e281befa0e52c929 100644
--- a/pkg/dev_compiler/lib/src/compiler/compiler.dart
+++ b/pkg/dev_compiler/lib/src/compiler/compiler.dart
@@ -498,9 +498,6 @@ class JSModuleFile {
if (options.sourceMap && sourceMap != null) {
builtMap =
placeSourceMap(sourceMap.build(jsUrl), mapUrl, options.bazelMapping);
- if (name == 'dart_sdk') {
- builtMap = cleanupSdkSourcemap(builtMap);
- }
if (options.sourceMapComment) {
var relativeMapUrl = path
.toUri(
@@ -586,6 +583,7 @@ Map placeSourceMap(
var list = new List.from(map['sources']);
map['sources'] = list;
String transformUri(String uri) {
+ if (uri.startsWith('dart:')) return uri;
var match = bazelMappings[path.absolute(uri)];
if (match != null) return match;
@@ -599,16 +597,3 @@ Map placeSourceMap(
map['file'] = transformUri(map['file']);
return map;
}
-
-/// Cleanup the dart_sdk source map.
-///
-/// Strip out files that should not be included in the sdk sourcemap as they
-/// are implementation details that would just confuse users.
-/// Normalize sdk urls to use "dart:" for more understandable stack traces.
-Map cleanupSdkSourcemap(Map sourceMap) {
- var map = new Map.from(sourceMap);
- map['sources'] = map['sources']
- .map((url) => url.contains('/_internal/') ? null : url)
- .toList();
- return map;
-}

Powered by Google App Engine
This is Rietveld 408576698