src/utils.h - Issue 2811333002: [builtins] HasOwnProperty: handle non-internalized string keys

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils.h

Issue 2811333002: [builtins] HasOwnProperty: handle non-internalized string keys (Closed)

Patch Set: rebased (noop) Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/utils.h

diff --git a/src/utils.h b/src/utils.h

index 887988a48845d1ac3fecac138baf3ef1014d3412..07ab118459be7522b0cda203dd056f1a89715533 100644

--- a/src/utils.h

+++ b/src/utils.h

@@ -313,7 +313,7 @@ class BitFieldBase {

static const T kMax = static_cast<T>((kOne << size) - 1);

// Tells whether the provided value fits into the bit field.

- static bool is_valid(T value) {

+ static constexpr bool is_valid(T value) {

return (static_cast<U>(value) & ~static_cast<U>(kMax)) == 0;

}

« no previous file with comments | « src/objects/string-table.h ('k') | no next file » | no next file with comments »