[builtins] HasOwnProperty: handle non-internalized string keys

src/builtins/builtins-object-gen.cc

 // Copyright 2017 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/builtins/builtins-utils-gen.h"
 #include "src/builtins/builtins.h"
 #include "src/code-stub-assembler.h"
 
 namespace v8 {
 namespace internal {
@@ skipping 50 matching lines @@
   Branch(TaggedIsSmi(object), &return_false, &if_objectisnotsmi);
   BIND(&if_objectisnotsmi);
 
   Node* map = LoadMap(object);
   Node* instance_type = LoadMapInstanceType(map);
 
   {
     VARIABLE(var_index, MachineType::PointerRepresentation());
     VARIABLE(var_unique, MachineRepresentation::kTagged);
 
-    Label keyisindex(this), if_iskeyunique(this);
-    TryToName(key, &keyisindex, &var_index, &if_iskeyunique, &var_unique,
-              &call_runtime);
+    Label if_index(this), if_unique_name(this), if_notunique_name(this);
+    TryToName(key, &if_index, &var_index, &if_unique_name, &var_unique,
+              &call_runtime, &if_notunique_name);
 
-    BIND(&if_iskeyunique);
+    BIND(&if_unique_name);
     TryHasOwnProperty(object, map, instance_type, var_unique.value(),
                       &return_true, &return_false, &call_runtime);
 
-    BIND(&keyisindex);
-    // Handle negative keys in the runtime.
-    GotoIf(IntPtrLessThan(var_index.value(), IntPtrConstant(0)), &call_runtime);
-    TryLookupElement(object, map, instance_type, var_index.value(),
-                     &return_true, &return_false, &return_false, &call_runtime);
+    BIND(&if_index);
+    {
+      // Handle negative keys in the runtime.
+      GotoIf(IntPtrLessThan(var_index.value(), IntPtrConstant(0)),
+             &call_runtime);
+      TryLookupElement(object, map, instance_type, var_index.value(),
+                       &return_true, &return_false, &return_false,
+                       &call_runtime);
+    }
+
+    BIND(&if_notunique_name);
+    {
+      Node* function = ExternalConstant(
+          ExternalReference::try_internalize_string_function(isolate()));
+      Node* result = CallCFunction1(MachineType::AnyTagged(),
+                                    MachineType::AnyTagged(), function, key);
+      // If internalization failed, then the string did not exist in the string
+      // table yet, which implies that no existing object has a property with
+      // that name.
+      Label internalized(this);
+      GotoIf(TaggedIsNotSmi(result), &internalized);
+      Node* int_result = SmiUntag(result);
+      GotoIf(WordEqual(int_result, IntPtrConstant(ResultSentinel::kNotFound)),
+             &return_false);
+      GotoIf(
+          WordEqual(int_result, IntPtrConstant(ResultSentinel::kUnsupported)),
+          &call_runtime);
+      var_index.Bind(int_result);
+      Goto(&if_index);
+
+      BIND(&internalized);
+      var_unique.Bind(result);
+      Goto(&if_unique_name);
+    }
   }
   BIND(&return_true);
   Return(BooleanConstant(true));
 
   BIND(&return_false);
   Return(BooleanConstant(false));
 
   BIND(&call_runtime);
   Return(CallRuntime(Runtime::kObjectHasOwnProperty, context, object, key));
 }
@@ skipping 301 matching lines @@
 
 TF_BUILTIN(GetSuperConstructor, ObjectBuiltinsAssembler) {
   Node* object = Parameter(Descriptor::kObject);
   Node* context = Parameter(Descriptor::kContext);
 
   Return(GetSuperConstructor(object, context));
 }
 
 }  // namespace internal
 }  // namespace v8