Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1595)

Unified Diff: content/browser/download/save_package.cc

Issue 2811293004: Fix an issue that we didn't clean url request properly. (Closed)
Patch Set: Fixed compiling for unit tests. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/save_package.cc
diff --git a/content/browser/download/save_package.cc b/content/browser/download/save_package.cc
index 3f9a643627ecae2d45ddbeb92f52336961c5414d..8945464156457dedeb6361bab24d6a2e566fe0b3 100644
--- a/content/browser/download/save_package.cc
+++ b/content/browser/download/save_package.cc
@@ -710,9 +710,9 @@ void SavePackage::Finish() {
// with SavePackage flow.
if (download_->GetState() == DownloadItem::IN_PROGRESS) {
if (save_type_ != SAVE_PAGE_TYPE_AS_MHTML) {
- download_->DestinationUpdate(
- all_save_items_count_, CurrentSpeed(),
- std::vector<DownloadItem::ReceivedSlice>());
+ download_->DestinationUpdate(all_save_items_count_, CurrentSpeed(),
+ std::vector<DownloadItem::ReceivedSlice>(),
+ std::unordered_set<int64_t>());
download_->OnAllDataSaved(all_save_items_count_,
std::unique_ptr<crypto::SecureHash>());
}
@@ -745,9 +745,9 @@ void SavePackage::SaveFinished(SaveItemId save_item_id,
// TODO(rdsmith/benjhayden): Integrate canceling on DownloadItem
// with SavePackage flow.
if (download_ && (download_->GetState() == DownloadItem::IN_PROGRESS)) {
- download_->DestinationUpdate(
- completed_count(), CurrentSpeed(),
- std::vector<DownloadItem::ReceivedSlice>());
+ download_->DestinationUpdate(completed_count(), CurrentSpeed(),
+ std::vector<DownloadItem::ReceivedSlice>(),
+ std::unordered_set<int64_t>());
}
if (save_item->save_source() == SaveFileCreateInfo::SAVE_FILE_FROM_DOM &&
« content/browser/download/download_job.h ('K') | « content/browser/download/parallel_download_job.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698