Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Unified Diff: content/browser/download/download_item_impl_unittest.cc

Issue 2811293004: Fix an issue that we didn't clean url request properly. (Closed)
Patch Set: Fixed compiling for unit tests. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_item_impl_unittest.cc
diff --git a/content/browser/download/download_item_impl_unittest.cc b/content/browser/download/download_item_impl_unittest.cc
index 5b87bfb80859f539cb3e0d2e617ec8a92d2cc829..1e00163a193aa73c7cfe26c3c9640b2f4a7219e2 100644
--- a/content/browser/download/download_item_impl_unittest.cc
+++ b/content/browser/download/download_item_impl_unittest.cc
@@ -432,7 +432,8 @@ TEST_F(DownloadItemTest, NotificationAfterUpdate) {
TestDownloadItemObserver observer(item);
item->DestinationUpdate(kDownloadChunkSize, kDownloadSpeed,
- std::vector<DownloadItem::ReceivedSlice>());
+ std::vector<DownloadItem::ReceivedSlice>(),
+ std::unordered_set<int64_t>());
ASSERT_TRUE(observer.CheckAndResetDownloadUpdated());
EXPECT_EQ(kDownloadSpeed, item->CurrentSpeed());
CleanupItem(item, file, DownloadItem::IN_PROGRESS);
@@ -979,8 +980,8 @@ TEST_F(DownloadItemTest, ClearReceivedSliceIfEtagChanged) {
EXPECT_CALL(*mock_delegate(), MockResumeInterruptedDownload(_, _));
EXPECT_CALL(*download_file, Detach());
- item->DestinationObserverAsWeakPtr()->DestinationUpdate(10, 100,
- kReceivedSlice);
+ item->DestinationObserverAsWeakPtr()->DestinationUpdate(
+ 10, 100, kReceivedSlice, std::unordered_set<int64_t>());
EXPECT_EQ(kReceivedSlice, item->GetReceivedSlices());
EXPECT_EQ(10, item->GetReceivedBytes());
@@ -1405,7 +1406,8 @@ TEST_F(DownloadItemTest, DestinationUpdate) {
std::vector<DownloadItem::ReceivedSlice> received_slices;
received_slices.emplace_back(0, 10);
- as_observer->DestinationUpdate(10, 20, received_slices);
+ as_observer->DestinationUpdate(10, 20, received_slices,
+ std::unordered_set<int64_t>());
EXPECT_EQ(20l, item->CurrentSpeed());
EXPECT_EQ(10l, item->GetReceivedBytes());
EXPECT_EQ(100l, item->GetTotalBytes());
@@ -1413,7 +1415,8 @@ TEST_F(DownloadItemTest, DestinationUpdate) {
EXPECT_TRUE(observer.CheckAndResetDownloadUpdated());
received_slices.emplace_back(200, 100);
- as_observer->DestinationUpdate(200, 20, received_slices);
+ as_observer->DestinationUpdate(200, 20, received_slices,
+ std::unordered_set<int64_t>());
EXPECT_EQ(20l, item->CurrentSpeed());
EXPECT_EQ(200l, item->GetReceivedBytes());
EXPECT_EQ(0l, item->GetTotalBytes());
@@ -1490,8 +1493,9 @@ TEST_F(DownloadItemTest, DestinationCompleted) {
EXPECT_FALSE(item->AllDataSaved());
EXPECT_FALSE(observer.CheckAndResetDownloadUpdated());
- as_observer->DestinationUpdate(
- 10, 20, std::vector<DownloadItem::ReceivedSlice>());
+ as_observer->DestinationUpdate(10, 20,
+ std::vector<DownloadItem::ReceivedSlice>(),
+ std::unordered_set<int64_t>());
EXPECT_TRUE(observer.CheckAndResetDownloadUpdated());
EXPECT_FALSE(observer.CheckAndResetDownloadUpdated()); // Confirm reset.
EXPECT_EQ(DownloadItem::IN_PROGRESS, item->GetState());
@@ -1948,7 +1952,8 @@ void DestinationUpdateInvoker(
<< ") observer:" << !!observer;
if (observer) {
observer->DestinationUpdate(bytes_so_far, bytes_per_sec,
- std::vector<DownloadItem::ReceivedSlice>());
+ std::vector<DownloadItem::ReceivedSlice>(),
+ std::unordered_set<int64_t>());
}
}

Powered by Google App Engine
This is Rietveld 408576698