Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: content/browser/download/download_file_unittest.cc

Issue 2811293004: Fix an issue that we didn't clean url request properly. (Closed)
Patch Set: Fixed compiling for unit tests. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_file_unittest.cc
diff --git a/content/browser/download/download_file_unittest.cc b/content/browser/download/download_file_unittest.cc
index 4bc430e2547808fd7a29f760dd46b037c0849382..6200aaf4b8b7987d3e8beb92a2a9adfd8654db3c 100644
--- a/content/browser/download/download_file_unittest.cc
+++ b/content/browser/download/download_file_unittest.cc
@@ -84,8 +84,11 @@ class MockByteStreamReader : public ByteStreamReader {
class MockDownloadDestinationObserver : public DownloadDestinationObserver {
public:
- MOCK_METHOD3(DestinationUpdate, void(
- int64_t, int64_t, const std::vector<DownloadItem::ReceivedSlice>&));
+ MOCK_METHOD4(DestinationUpdate,
+ void(int64_t,
+ int64_t,
+ const std::vector<DownloadItem::ReceivedSlice>&,
+ const std::unordered_set<int64_t>&));
void DestinationError(
DownloadInterruptReason reason,
int64_t bytes_so_far,
@@ -175,8 +178,10 @@ class DownloadFileTest : public testing::Test {
~DownloadFileTest() override {}
void SetUpdateDownloadInfo(
- int64_t bytes, int64_t bytes_per_sec,
- const std::vector<DownloadItem::ReceivedSlice>& received_slices) {
+ int64_t bytes,
+ int64_t bytes_per_sec,
+ const std::vector<DownloadItem::ReceivedSlice>& received_slices,
+ const std::unordered_set<int64_t>& streams_to_close) {
bytes_ = bytes;
bytes_per_sec_ = bytes_per_sec;
}
@@ -186,7 +191,7 @@ class DownloadFileTest : public testing::Test {
}
void SetUp() override {
- EXPECT_CALL(*(observer_.get()), DestinationUpdate(_, _, _))
+ EXPECT_CALL(*(observer_.get()), DestinationUpdate(_, _, _, _))
.Times(AnyNumber())
.WillRepeatedly(Invoke(this, &DownloadFileTest::SetUpdateDownloadInfo));
}
@@ -346,7 +351,7 @@ class DownloadFileTest : public testing::Test {
MockDestinationCompleted(_, expected_hash));
base::RunLoop().RunUntilIdle();
::testing::Mock::VerifyAndClearExpectations(observer_.get());
- EXPECT_CALL(*(observer_.get()), DestinationUpdate(_, _, _))
+ EXPECT_CALL(*(observer_.get()), DestinationUpdate(_, _, _, _))
.Times(AnyNumber())
.WillRepeatedly(
Invoke(this, &DownloadFileTest::SetUpdateDownloadInfo));

Powered by Google App Engine
This is Rietveld 408576698