Remove ListValue::Append(raw ptr) on Android

content/browser/android/java/gin_java_method_invocation_helper.cc

Index: content/browser/android/java/gin_java_method_invocation_helper.cc
diff --git a/content/browser/android/java/gin_java_method_invocation_helper.cc b/content/browser/android/java/gin_java_method_invocation_helper.cc
index 1a5d1df6a06cf321e757f6f13ade1f8750699bf7..6c5edab76ce42d3a2d52f8b36dc4f8b92a3ad4ef 100644
--- a/content/browser/android/java/gin_java_method_invocation_helper.cc
+++ b/content/browser/android/java/gin_java_method_invocation_helper.cc
@@ -258,8 +258,7 @@ void GinJavaMethodInvocationHelper::InvokeMethod(jobject object,
       if (std::isfinite(result)) {
         result_wrapper.AppendDouble(result);
       } else {
-        result_wrapper.Append(
-            GinJavaBridgeValue::CreateNonFiniteValue(result).release());
+        result_wrapper.Append(GinJavaBridgeValue::CreateNonFiniteValue(result));

[jdoerrie, 2017/04/12 16:08:55]

Consider removing the braces around if and else.

[vabr (Chromium), 2017/04/12 16:40:53]

Looking around the file, it uses braces also for single line statements. The
style guide allows that and mandates consistency. So in this case I think
keeping the braces is better.

[jdoerrie, 2017/04/12 18:30:19]

Acknowledged.

       }
       break;
     }
@@ -270,8 +269,7 @@ void GinJavaMethodInvocationHelper::InvokeMethod(jobject object,
       if (std::isfinite(result)) {
         result_wrapper.AppendDouble(result);
       } else {
-        result_wrapper.Append(
-            GinJavaBridgeValue::CreateNonFiniteValue(result).release());
+        result_wrapper.Append(GinJavaBridgeValue::CreateNonFiniteValue(result));

[jdoerrie, 2017/04/12 16:08:55]

Same here.

       }
       break;
     }
@@ -280,15 +278,13 @@ void GinJavaMethodInvocationHelper::InvokeMethod(jobject object,
         env->CallVoidMethodA(object, id, parameters);
       else
         env->CallStaticVoidMethodA(clazz, id, parameters);
-      result_wrapper.Append(
-          GinJavaBridgeValue::CreateUndefinedValue().release());
+      result_wrapper.Append(GinJavaBridgeValue::CreateUndefinedValue());
       break;
     case JavaType::TypeArray:
       // LIVECONNECT_COMPLIANCE: Existing behavior is to not call methods that
       // return arrays. Spec requires calling the method and converting the
       // result to a JavaScript array.
-      result_wrapper.Append(
-          GinJavaBridgeValue::CreateUndefinedValue().release());
+      result_wrapper.Append(GinJavaBridgeValue::CreateUndefinedValue());
       break;
     case JavaType::TypeString: {
       jstring java_string = static_cast<jstring>(
@@ -305,8 +301,7 @@ void GinJavaMethodInvocationHelper::InvokeMethod(jobject object,
       if (!scoped_java_string.obj()) {
         // LIVECONNECT_COMPLIANCE: Existing behavior is to return undefined.
         // Spec requires returning a null string.
-        result_wrapper.Append(
-            GinJavaBridgeValue::CreateUndefinedValue().release());
+        result_wrapper.Append(GinJavaBridgeValue::CreateUndefinedValue());
         break;
       }
       result_wrapper.AppendString(