Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/objects-debug.cc

Issue 2811183005: Do not use new struct type where unnecessary. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/objects.h" 5 #include "src/objects.h"
6 6
7 #include "src/assembler-inl.h" 7 #include "src/assembler-inl.h"
8 #include "src/bootstrapper.h" 8 #include "src/bootstrapper.h"
9 #include "src/disasm.h" 9 #include "src/disasm.h"
10 #include "src/disassembler.h" 10 #include "src/disassembler.h"
(...skipping 410 matching lines...) Expand 10 before | Expand all | Expand 10 after
421 void Map::VerifyOmittedMapChecks() { 421 void Map::VerifyOmittedMapChecks() {
422 if (!FLAG_omit_map_checks_for_leaf_maps) return; 422 if (!FLAG_omit_map_checks_for_leaf_maps) return;
423 if (!is_stable() || 423 if (!is_stable() ||
424 is_deprecated() || 424 is_deprecated() ||
425 is_dictionary_map()) { 425 is_dictionary_map()) {
426 CHECK(dependent_code()->IsEmpty(DependentCode::kPrototypeCheckGroup)); 426 CHECK(dependent_code()->IsEmpty(DependentCode::kPrototypeCheckGroup));
427 } 427 }
428 } 428 }
429 429
430 430
431 void TypeFeedbackInfo::TypeFeedbackInfoVerify() {
432 VerifyObjectField(kStorage1Offset);
433 VerifyObjectField(kStorage2Offset);
434 VerifyObjectField(kStorage3Offset);
435 }
436
437
438 void AliasedArgumentsEntry::AliasedArgumentsEntryVerify() { 431 void AliasedArgumentsEntry::AliasedArgumentsEntryVerify() {
439 VerifySmiField(kAliasedContextSlot); 432 VerifySmiField(kAliasedContextSlot);
440 } 433 }
441 434
442 435
443 void FixedArray::FixedArrayVerify() { 436 void FixedArray::FixedArrayVerify() {
444 for (int i = 0; i < length(); i++) { 437 for (int i = 0; i < length(); i++) {
445 Object* e = get(i); 438 Object* e = get(i);
446 VerifyPointer(e); 439 VerifyPointer(e);
447 } 440 }
(...skipping 715 matching lines...) Expand 10 before | Expand all | Expand 10 after
1163 VerifyObjectField(kValue2Offset); 1156 VerifyObjectField(kValue2Offset);
1164 VerifyObjectField(kValue3Offset); 1157 VerifyObjectField(kValue3Offset);
1165 } 1158 }
1166 1159
1167 void ContextExtension::ContextExtensionVerify() { 1160 void ContextExtension::ContextExtensionVerify() {
1168 CHECK(IsContextExtension()); 1161 CHECK(IsContextExtension());
1169 VerifyObjectField(kScopeInfoOffset); 1162 VerifyObjectField(kScopeInfoOffset);
1170 VerifyObjectField(kExtensionOffset); 1163 VerifyObjectField(kExtensionOffset);
1171 } 1164 }
1172 1165
1173 void ConstantElementsPair::ConstantElementsPairVerify() {
1174 CHECK(IsConstantElementsPair());
1175 VerifySmiField(kElementsKindOffset);
1176 VerifyObjectField(kConstantValuesOffset);
1177 }
1178
1179 void AccessorInfo::AccessorInfoVerify() { 1166 void AccessorInfo::AccessorInfoVerify() {
1180 CHECK(IsAccessorInfo()); 1167 CHECK(IsAccessorInfo());
1181 VerifyPointer(name()); 1168 VerifyPointer(name());
1182 VerifyPointer(expected_receiver_type()); 1169 VerifyPointer(expected_receiver_type());
1183 VerifyPointer(getter()); 1170 VerifyPointer(getter());
1184 VerifyPointer(setter()); 1171 VerifyPointer(setter());
1185 VerifyPointer(js_getter()); 1172 VerifyPointer(js_getter());
1186 VerifyPointer(data()); 1173 VerifyPointer(data());
1187 } 1174 }
1188 1175
(...skipping 19 matching lines...) Expand all
1208 VerifyPointer(getter()); 1195 VerifyPointer(getter());
1209 VerifyPointer(setter()); 1196 VerifyPointer(setter());
1210 VerifyPointer(query()); 1197 VerifyPointer(query());
1211 VerifyPointer(deleter()); 1198 VerifyPointer(deleter());
1212 VerifyPointer(enumerator()); 1199 VerifyPointer(enumerator());
1213 VerifyPointer(data()); 1200 VerifyPointer(data());
1214 VerifySmiField(kFlagsOffset); 1201 VerifySmiField(kFlagsOffset);
1215 } 1202 }
1216 1203
1217 1204
1218 void CallHandlerInfo::CallHandlerInfoVerify() {
1219 CHECK(IsCallHandlerInfo());
1220 VerifyPointer(callback());
1221 VerifyPointer(data());
1222 }
1223
1224
1225 void TemplateInfo::TemplateInfoVerify() { 1205 void TemplateInfo::TemplateInfoVerify() {
1226 VerifyPointer(tag()); 1206 VerifyPointer(tag());
1227 VerifyPointer(property_list()); 1207 VerifyPointer(property_list());
1228 VerifyPointer(property_accessors()); 1208 VerifyPointer(property_accessors());
1229 } 1209 }
1230 1210
1231 1211
1232 void FunctionTemplateInfo::FunctionTemplateInfoVerify() { 1212 void FunctionTemplateInfo::FunctionTemplateInfoVerify() {
1233 CHECK(IsFunctionTemplateInfo()); 1213 CHECK(IsFunctionTemplateInfo());
1234 TemplateInfoVerify(); 1214 TemplateInfoVerify();
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
1291 1271
1292 1272
1293 void DebugInfo::DebugInfoVerify() { 1273 void DebugInfo::DebugInfoVerify() {
1294 CHECK(IsDebugInfo()); 1274 CHECK(IsDebugInfo());
1295 VerifyPointer(shared()); 1275 VerifyPointer(shared());
1296 VerifyPointer(debug_bytecode_array()); 1276 VerifyPointer(debug_bytecode_array());
1297 VerifyPointer(break_points()); 1277 VerifyPointer(break_points());
1298 } 1278 }
1299 1279
1300 1280
1301 void BreakPointInfo::BreakPointInfoVerify() {
1302 CHECK(IsBreakPointInfo());
1303 VerifyPointer(break_point_objects());
1304 }
1305
1306 void StackFrameInfo::StackFrameInfoVerify() { 1281 void StackFrameInfo::StackFrameInfoVerify() {
1307 CHECK(IsStackFrameInfo()); 1282 CHECK(IsStackFrameInfo());
1308 VerifyPointer(script_name()); 1283 VerifyPointer(script_name());
1309 VerifyPointer(script_name_or_source_url()); 1284 VerifyPointer(script_name_or_source_url());
1310 VerifyPointer(function_name()); 1285 VerifyPointer(function_name());
1311 } 1286 }
1312 #endif // VERIFY_HEAP 1287 #endif // VERIFY_HEAP
1313 1288
1314 #ifdef DEBUG 1289 #ifdef DEBUG
1315 1290
(...skipping 282 matching lines...) Expand 10 before | Expand all | Expand 10 after
1598 1573
1599 // Both are done at the same time. 1574 // Both are done at the same time.
1600 CHECK_EQ(new_it.done(), old_it.done()); 1575 CHECK_EQ(new_it.done(), old_it.done());
1601 } 1576 }
1602 1577
1603 1578
1604 #endif // DEBUG 1579 #endif // DEBUG
1605 1580
1606 } // namespace internal 1581 } // namespace internal
1607 } // namespace v8 1582 } // namespace v8
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698