Media Capabilities encoding: Blink pass-thru and skeleton renderer/ impl

third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.cpp

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/media_capabilities/MediaCapabilities.h"
 
 #include "bindings/core/v8/CallbackPromiseAdapter.h"
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "bindings/core/v8/ScriptState.h"
+#include "core/dom/DOMException.h"
 #include "modules/media_capabilities/MediaCapabilitiesInfo.h"
+#include "modules/media_capabilities/MediaConfiguration.h"
 #include "modules/media_capabilities/MediaDecodingConfiguration.h"
+#include "modules/media_capabilities/MediaEncodingConfiguration.h"
 #include "public/platform/Platform.h"
+#include "public/platform/WebMediaRecorderHandler.h"
 #include "public/platform/modules/media_capabilities/WebMediaCapabilitiesClient.h"
 #include "public/platform/modules/media_capabilities/WebMediaCapabilitiesInfo.h"
 #include "public/platform/modules/media_capabilities/WebMediaConfiguration.h"
 
 namespace blink {
 
 namespace {
 
 WebAudioConfiguration ToWebAudioConfiguration(
     const AudioConfiguration& configuration) {
@@ skipping 34 matching lines @@
   DCHECK(configuration.hasBitrate());
   web_configuration.bitrate = configuration.bitrate();
 
   DCHECK(configuration.hasFramerate());
   web_configuration.framerate = configuration.framerate();
 
   return web_configuration;
 }
 
 WebMediaConfiguration ToWebMediaConfiguration(
-    const MediaDecodingConfiguration& configuration) {
+    const MediaConfiguration& configuration) {
   WebMediaConfiguration web_configuration;
 
-  // |type| is mandatory.
-  DCHECK(configuration.hasType());
-
   if (configuration.hasAudio()) {
     web_configuration.audio_configuration =
         ToWebAudioConfiguration(configuration.audio());
   }
 
   if (configuration.hasVideo()) {
     web_configuration.video_configuration =
         ToWebVideoConfiguration(configuration.video());
   }
 
   return web_configuration;
 }
 
 }  // anonymous namespace
 
 MediaCapabilities::MediaCapabilities() = default;
 
 ScriptPromise MediaCapabilities::decodingInfo(
     ScriptState* script_state,
     const MediaDecodingConfiguration& configuration) {
   ScriptPromiseResolver* resolver = ScriptPromiseResolver::Create(script_state);
   ScriptPromise promise = resolver->Promise();
 
+  // |type| is mandatory.
+  DCHECK(configuration.hasType());
+
   Platform::Current()->MediaCapabilitiesClient()->DecodingInfo(
       ToWebMediaConfiguration(configuration),
       WTF::MakeUnique<CallbackPromiseAdapter<MediaCapabilitiesInfo, void>>(
           resolver));
 
   return promise;
 }
 
+ScriptPromise MediaCapabilities::encodingInfo(
+    ScriptState* script_state,
+    const MediaEncodingConfiguration& configuration) {
+  ScriptPromiseResolver* resolver = ScriptPromiseResolver::Create(script_state);
+  ScriptPromise promise = resolver->Promise();
+
+  if (!configuration.hasVideo() && !configuration.hasAudio()) {
+    resolver->Reject(DOMException::Create(kSyntaxError,
+                                          "Either |video| or |audio| needed."));

[haraken, 2017/04/20 19:55:18]

Add a more developer-friendly message.

[mcasas, 2017/04/20 21:12:02]

Done.

+    return promise;
+  }
+
+  WebMediaRecorderHandler* handler =
+      Platform::Current()->CreateMediaRecorderHandler();
+  if (!handler) {
+    resolver->Reject(
+        DOMException::Create(kInvalidStateError, "Platform error"));

[haraken, 2017/04/20 19:55:18]

Ditto.

[mcasas, 2017/04/20 21:12:02]

Done.

+    return promise;
+  }
+
+  handler->EncodingInfo(

[haraken, 2017/04/20 19:55:18]

Why do you use a different pattern between decodingInfo and encodingInfo?
decodingInfo is using
Platform::Current()->MediaCapabilitiesClient()->DecodingInfo. If we follow that
pattern, we won't need to add a public API.

[mcasas, 2017/04/20 21:12:02]

Decoding and Encoding need to go to different places to
retrieve the results of the query: decoding goes to 
media/ whereas encoding has to go to 
content/renderer/media_recorder.

+      ToWebMediaConfiguration(configuration),
+      WTF::MakeUnique<CallbackPromiseAdapter<MediaCapabilitiesInfo, void>>(
+          resolver));
+  return promise;
+}
+
 DEFINE_TRACE(MediaCapabilities) {}
 
 }  // namespace blink