Attempt at capturing screenshot on IE if tests time out

Attempt at capturing screenshot on IE if tests time out

The hypothesis is that a modal dialog from Internet Explorer causes
the currently running test to hang until test.dart kills the browser.

Capturing a screenshot might give an insight into there is a dialog showing up.

BUG=https://github.com/dart-lang/sdk/issues/28955
R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/a3e9cd8ff6c88949a4ef1ddbb3c4a7b7cdf9d33c

[kustermann, 2017-04-11 14:17:30]

kustermann@google.com changed reviewers:
+ johnniwinther@google.com, whesse@google.com

[Johnni Winther, 2017-04-12 07:16:09]

lgtm

[Bill Hesse, 2017-04-12 08:38:21]

Looks good to me you could add a copyright notice to The powershell Script and
maybe a time out and or try finally for the capture screenshot but it is fine
without that too

[kustermann, 2017-04-12 08:57:13]

On 2017/04/12 08:38:21, Bill Hesse wrote:
> Looks good to me you could add a copyright notice to The powershell Script and
> maybe a time out and or try finally for the capture screenshot but it is fine
> without that too

The only case when this throws is when the executable doesn't exist, in which
case I would rather not swallow the error.

[kustermann, 2017-04-12 08:57:25]

Thanks!

[kustermann, 2017-04-12 08:58:03]

Description was changed from

==========
Attempt at capturing screenshot on IE if tests time out

The hypothesis is that a modal dialog from Internet Explorer causes
the currently running test to hang until test.dart kills the browser.

Capturing a screenshot might give an insight into there is a dialog showing up.

BUG=https://github.com/dart-lang/sdk/issues/28955
==========

to

==========
Attempt at capturing screenshot on IE if tests time out

The hypothesis is that a modal dialog from Internet Explorer causes
the currently running test to hang until test.dart kills the browser.

Capturing a screenshot might give an insight into there is a dialog showing up.

BUG=https://github.com/dart-lang/sdk/issues/28955
R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a3e9cd8ff6c88949a4ef1ddbb3c4a7b7cdf9d33c
==========

[kustermann, 2017-04-12 08:58:04]

Committed patchset #2 (id:20001) manually as
a3e9cd8ff6c88949a4ef1ddbb3c4a7b7cdf9d33c (presubmit successful).