Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 2811083004: (False positive) Revert of Track if a ReadingListEntry has been dismissed (Closed)

Created:
3 years, 8 months ago by findit-for-me
Modified:
3 years, 8 months ago
Reviewers:
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Track if a ReadingListEntry has been dismissed (patchset #7 id:120001 of https://codereview.chromium.org/2806213004/ ) Reason for revert: Findit identified CL at revision 463615 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzAwNDMwMTMyMjlmZmZhYjM1NTVkYWYyOGM2NGVlMjc1MjEyMDlkN2IM Original issue's description: > Track if a ReadingListEntry has been dismissed > > This CL adds a field to the ReadingListEntry, saved only on the device, to > track if the entry has been dismissed from the NTP. > The only way to change the extra information is to use the model, allowing > the data to be stored. > > BUG=707730 > > Review-Url: https://codereview.chromium.org/2806213004 > Cr-Commit-Position: refs/heads/master@{#463615} > Committed: https://chromium.googlesource.com/chromium/src/+/0043013229fffab3555daf28c64ee27521209d7b TBR=olivierrobin@chromium.org,treib@chromium.org,gambard@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=707730

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -129 lines) Patch
M components/reading_list/core/proto/reading_list.proto View 1 chunk +0 lines, -6 lines 0 comments Download
M components/reading_list/core/reading_list_entry.h View 4 chunks +14 lines, -31 lines 0 comments Download
M components/reading_list/core/reading_list_entry.cc View 9 chunks +7 lines, -36 lines 0 comments Download
M components/reading_list/core/reading_list_entry_unittest.cc View 5 chunks +0 lines, -12 lines 0 comments Download
M components/reading_list/core/reading_list_model.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/reading_list/core/reading_list_model_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/reading_list/core/reading_list_model_impl.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M components/reading_list/core/reading_list_model_unittest.cc View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
findit-for-me
Created Revert of Track if a ReadingListEntry has been dismissed
3 years, 8 months ago (2017-04-11 14:53:37 UTC) #1
findit-for-me
Sheriffs: Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct. If ...
3 years, 8 months ago (2017-04-11 14:53:38 UTC) #3
stgao
On 2017/04/11 14:53:38, findit-for-me wrote: > Sheriffs: > > Please confirm and "Quick L-G-T-M & ...
3 years, 8 months ago (2017-04-11 17:39:43 UTC) #6
stgao
On 2017/04/11 17:39:43, stgao(ping after 24h) wrote: > On 2017/04/11 14:53:38, findit-for-me wrote: > > ...
3 years, 8 months ago (2017-04-26 20:47:24 UTC) #7
stgao
3 years, 8 months ago (2017-04-26 20:47:39 UTC) #8
Message was sent while issue was closed.
On 2017/04/26 20:47:24, stgao(ping after 24h) wrote:
> On 2017/04/11 17:39:43, stgao(ping after 24h) wrote:
> > On 2017/04/11 14:53:38, findit-for-me wrote:
> > > Sheriffs:
> > > 
> > > Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct.
> > > If it is a false positive, please close it.
> > > 
> > > The original CL was identified as the culprit for failures in the build
> > > cycles as shown on:
> > >
> >
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
> > 
> > This is a false positive due to flaky compile. Incorrect config for
dependency
> > on a generated header file net/net_features.h
> 
> Testing findit link
> Findit (https://goo.gl/kROfz5) blabla....

Testing findit link
Findit(https://goo.gl/kROfz5) blabla....

Powered by Google App Engine
This is Rietveld 408576698