Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: components/viz/frame_sinks/frame_eviction_manager.cc

Issue 2811083002: Move frame eviction into components (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/renderer_frame_manager.h" 5 #include "components/viz/frame_sinks/frame_eviction_manager.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
11 #include "base/memory/memory_coordinator_client_registry.h" 11 #include "base/memory/memory_coordinator_client_registry.h"
12 #include "base/memory/memory_coordinator_proxy.h" 12 #include "base/memory/memory_coordinator_proxy.h"
13 #include "base/memory/memory_pressure_listener.h" 13 #include "base/memory/memory_pressure_listener.h"
14 #include "base/memory/memory_pressure_monitor.h" 14 #include "base/memory/memory_pressure_monitor.h"
15 #include "base/memory/shared_memory.h" 15 #include "base/memory/shared_memory.h"
16 #include "base/sys_info.h" 16 #include "base/sys_info.h"
17 #include "build/build_config.h" 17 #include "build/build_config.h"
18 #include "components/display_compositor/host_shared_bitmap_manager.h" 18 #include "components/display_compositor/host_shared_bitmap_manager.h"
19 #include "content/public/common/content_features.h"
20 19
21 namespace content { 20 namespace viz {
22 namespace { 21 namespace {
23 22
24 const int kModeratePressurePercentage = 50; 23 const int kModeratePressurePercentage = 50;
25 const int kCriticalPressurePercentage = 10; 24 const int kCriticalPressurePercentage = 10;
26 25
27 } // namespace 26 } // namespace
28 27
29 RendererFrameManager* RendererFrameManager::GetInstance() { 28 FrameEvictionManager* FrameEvictionManager::GetInstance() {
30 return base::Singleton<RendererFrameManager>::get(); 29 return base::Singleton<FrameEvictionManager>::get();
31 } 30 }
32 31
33 void RendererFrameManager::AddFrame(RendererFrameManagerClient* frame, 32 void FrameEvictionManager::AddFrame(FrameEvictionManagerClient* frame,
34 bool locked) { 33 bool locked) {
35 RemoveFrame(frame); 34 RemoveFrame(frame);
36 if (locked) 35 if (locked)
37 locked_frames_[frame] = 1; 36 locked_frames_[frame] = 1;
38 else 37 else
39 unlocked_frames_.push_front(frame); 38 unlocked_frames_.push_front(frame);
40 CullUnlockedFrames(GetMaxNumberOfSavedFrames()); 39 CullUnlockedFrames(GetMaxNumberOfSavedFrames());
41 } 40 }
42 41
43 void RendererFrameManager::RemoveFrame(RendererFrameManagerClient* frame) { 42 void FrameEvictionManager::RemoveFrame(FrameEvictionManagerClient* frame) {
44 std::map<RendererFrameManagerClient*, size_t>::iterator locked_iter = 43 std::map<FrameEvictionManagerClient*, size_t>::iterator locked_iter =
45 locked_frames_.find(frame); 44 locked_frames_.find(frame);
46 if (locked_iter != locked_frames_.end()) 45 if (locked_iter != locked_frames_.end())
47 locked_frames_.erase(locked_iter); 46 locked_frames_.erase(locked_iter);
48 unlocked_frames_.remove(frame); 47 unlocked_frames_.remove(frame);
49 } 48 }
50 49
51 void RendererFrameManager::LockFrame(RendererFrameManagerClient* frame) { 50 void FrameEvictionManager::LockFrame(FrameEvictionManagerClient* frame) {
52 std::list<RendererFrameManagerClient*>::iterator unlocked_iter = 51 std::list<FrameEvictionManagerClient*>::iterator unlocked_iter =
53 std::find(unlocked_frames_.begin(), unlocked_frames_.end(), frame); 52 std::find(unlocked_frames_.begin(), unlocked_frames_.end(), frame);
54 if (unlocked_iter != unlocked_frames_.end()) { 53 if (unlocked_iter != unlocked_frames_.end()) {
55 DCHECK(locked_frames_.find(frame) == locked_frames_.end()); 54 DCHECK(locked_frames_.find(frame) == locked_frames_.end());
56 unlocked_frames_.remove(frame); 55 unlocked_frames_.remove(frame);
57 locked_frames_[frame] = 1; 56 locked_frames_[frame] = 1;
58 } else { 57 } else {
59 DCHECK(locked_frames_.find(frame) != locked_frames_.end()); 58 DCHECK(locked_frames_.find(frame) != locked_frames_.end());
60 locked_frames_[frame]++; 59 locked_frames_[frame]++;
61 } 60 }
62 } 61 }
63 62
64 void RendererFrameManager::UnlockFrame(RendererFrameManagerClient* frame) { 63 void FrameEvictionManager::UnlockFrame(FrameEvictionManagerClient* frame) {
65 DCHECK(locked_frames_.find(frame) != locked_frames_.end()); 64 DCHECK(locked_frames_.find(frame) != locked_frames_.end());
66 size_t locked_count = locked_frames_[frame]; 65 size_t locked_count = locked_frames_[frame];
67 DCHECK(locked_count); 66 DCHECK(locked_count);
68 if (locked_count > 1) { 67 if (locked_count > 1) {
69 locked_frames_[frame]--; 68 locked_frames_[frame]--;
70 } else { 69 } else {
71 RemoveFrame(frame); 70 RemoveFrame(frame);
72 unlocked_frames_.push_front(frame); 71 unlocked_frames_.push_front(frame);
73 CullUnlockedFrames(GetMaxNumberOfSavedFrames()); 72 CullUnlockedFrames(GetMaxNumberOfSavedFrames());
74 } 73 }
75 } 74 }
76 75
77 size_t RendererFrameManager::GetMaxNumberOfSavedFrames() const { 76 size_t FrameEvictionManager::GetMaxNumberOfSavedFrames() const {
78 int percentage = 100; 77 int percentage = 100;
79 if (base::FeatureList::IsEnabled(features::kMemoryCoordinator)) { 78 auto* memory_coordinator_proxy = base::MemoryCoordinatorProxy::GetInstance();
80 switch (base::MemoryCoordinatorProxy::GetInstance()-> 79 if (memory_coordinator_proxy) {
81 GetCurrentMemoryState()) { 80 switch (memory_coordinator_proxy->GetCurrentMemoryState()) {
82 case base::MemoryState::NORMAL: 81 case base::MemoryState::NORMAL:
83 percentage = 100; 82 percentage = 100;
84 break; 83 break;
85 case base::MemoryState::THROTTLED: 84 case base::MemoryState::THROTTLED:
86 percentage = kCriticalPressurePercentage; 85 percentage = kCriticalPressurePercentage;
87 break; 86 break;
88 case base::MemoryState::SUSPENDED: 87 case base::MemoryState::SUSPENDED:
89 case base::MemoryState::UNKNOWN: 88 case base::MemoryState::UNKNOWN:
90 NOTREACHED(); 89 NOTREACHED();
91 break; 90 break;
(...skipping 15 matching lines...) Expand all
107 break; 106 break;
108 case base::MemoryPressureListener::MEMORY_PRESSURE_LEVEL_CRITICAL: 107 case base::MemoryPressureListener::MEMORY_PRESSURE_LEVEL_CRITICAL:
109 percentage = kCriticalPressurePercentage; 108 percentage = kCriticalPressurePercentage;
110 break; 109 break;
111 } 110 }
112 } 111 }
113 size_t frames = (max_number_of_saved_frames_ * percentage) / 100; 112 size_t frames = (max_number_of_saved_frames_ * percentage) / 100;
114 return std::max(static_cast<size_t>(1), frames); 113 return std::max(static_cast<size_t>(1), frames);
115 } 114 }
116 115
117 RendererFrameManager::RendererFrameManager() 116 FrameEvictionManager::FrameEvictionManager()
118 : memory_pressure_listener_(new base::MemoryPressureListener( 117 : memory_pressure_listener_(new base::MemoryPressureListener(
119 base::Bind(&RendererFrameManager::OnMemoryPressure, 118 base::Bind(&FrameEvictionManager::OnMemoryPressure,
120 base::Unretained(this)))) { 119 base::Unretained(this)))) {
121 base::MemoryCoordinatorClientRegistry::GetInstance()->Register(this); 120 base::MemoryCoordinatorClientRegistry::GetInstance()->Register(this);
122 max_number_of_saved_frames_ = 121 max_number_of_saved_frames_ =
123 #if defined(OS_ANDROID) 122 #if defined(OS_ANDROID)
124 // If the amount of memory on the device is >= 3.5 GB, save up to 5 123 // If the amount of memory on the device is >= 3.5 GB, save up to 5
125 // frames. 124 // frames.
126 base::SysInfo::AmountOfPhysicalMemoryMB() < 1024 * 3.5f ? 1 : 5; 125 base::SysInfo::AmountOfPhysicalMemoryMB() < 1024 * 3.5f ? 1 : 5;
127 #else 126 #else
128 std::min(5, 2 + (base::SysInfo::AmountOfPhysicalMemoryMB() / 256)); 127 std::min(5, 2 + (base::SysInfo::AmountOfPhysicalMemoryMB() / 256));
129 #endif 128 #endif
130 max_handles_ = base::SharedMemory::GetHandleLimit() / 8.0f; 129 max_handles_ = base::SharedMemory::GetHandleLimit() / 8.0f;
131 } 130 }
132 131
133 RendererFrameManager::~RendererFrameManager() {} 132 FrameEvictionManager::~FrameEvictionManager() {}
134 133
135 void RendererFrameManager::CullUnlockedFrames(size_t saved_frame_limit) { 134 void FrameEvictionManager::CullUnlockedFrames(size_t saved_frame_limit) {
136 if (unlocked_frames_.size() + locked_frames_.size() > 0) { 135 if (unlocked_frames_.size() + locked_frames_.size() > 0) {
137 float handles_per_frame = 136 float handles_per_frame =
138 display_compositor::HostSharedBitmapManager::current() 137 display_compositor::HostSharedBitmapManager::current()
139 ->AllocatedBitmapCount() * 138 ->AllocatedBitmapCount() *
140 1.0f / (unlocked_frames_.size() + locked_frames_.size()); 139 1.0f / (unlocked_frames_.size() + locked_frames_.size());
141 140
142 saved_frame_limit = std::max( 141 saved_frame_limit = std::max(
143 1, 142 1, static_cast<int>(std::min(static_cast<float>(saved_frame_limit),
144 static_cast<int>(std::min(static_cast<float>(saved_frame_limit), 143 max_handles_ / handles_per_frame)));
145 max_handles_ / handles_per_frame)));
146 } 144 }
147 while (!unlocked_frames_.empty() && 145 while (!unlocked_frames_.empty() &&
148 unlocked_frames_.size() + locked_frames_.size() > saved_frame_limit) { 146 unlocked_frames_.size() + locked_frames_.size() > saved_frame_limit) {
149 size_t old_size = unlocked_frames_.size(); 147 size_t old_size = unlocked_frames_.size();
150 // Should remove self from list. 148 // Should remove self from list.
151 unlocked_frames_.back()->EvictCurrentFrame(); 149 unlocked_frames_.back()->EvictCurrentFrame();
152 DCHECK_EQ(unlocked_frames_.size() + 1, old_size); 150 DCHECK_EQ(unlocked_frames_.size() + 1, old_size);
153 } 151 }
154 } 152 }
155 153
156 void RendererFrameManager::OnMemoryPressure( 154 void FrameEvictionManager::OnMemoryPressure(
157 base::MemoryPressureListener::MemoryPressureLevel memory_pressure_level) { 155 base::MemoryPressureListener::MemoryPressureLevel memory_pressure_level) {
158 switch (memory_pressure_level) { 156 switch (memory_pressure_level) {
159 case base::MemoryPressureListener::MEMORY_PRESSURE_LEVEL_MODERATE: 157 case base::MemoryPressureListener::MEMORY_PRESSURE_LEVEL_MODERATE:
160 PurgeMemory(kModeratePressurePercentage); 158 PurgeMemory(kModeratePressurePercentage);
161 break; 159 break;
162 case base::MemoryPressureListener::MEMORY_PRESSURE_LEVEL_CRITICAL: 160 case base::MemoryPressureListener::MEMORY_PRESSURE_LEVEL_CRITICAL:
163 PurgeMemory(kCriticalPressurePercentage); 161 PurgeMemory(kCriticalPressurePercentage);
164 break; 162 break;
165 case base::MemoryPressureListener::MEMORY_PRESSURE_LEVEL_NONE: 163 case base::MemoryPressureListener::MEMORY_PRESSURE_LEVEL_NONE:
166 // No need to change anything when there is no pressure. 164 // No need to change anything when there is no pressure.
167 return; 165 return;
168 } 166 }
169 } 167 }
170 168
171 void RendererFrameManager::OnPurgeMemory() { 169 void FrameEvictionManager::OnPurgeMemory() {
172 PurgeMemory(kCriticalPressurePercentage); 170 PurgeMemory(kCriticalPressurePercentage);
173 } 171 }
174 172
175 void RendererFrameManager::PurgeMemory(int percentage) { 173 void FrameEvictionManager::PurgeMemory(int percentage) {
176 int saved_frame_limit = max_number_of_saved_frames_; 174 int saved_frame_limit = max_number_of_saved_frames_;
177 if (saved_frame_limit <= 1) 175 if (saved_frame_limit <= 1)
178 return; 176 return;
179 CullUnlockedFrames(std::max(1, (saved_frame_limit * percentage) / 100)); 177 CullUnlockedFrames(std::max(1, (saved_frame_limit * percentage) / 100));
180 } 178 }
181 179
182 } // namespace content 180 } // namespace viz
OLDNEW
« no previous file with comments | « components/viz/frame_sinks/frame_eviction_manager.h ('k') | components/viz/frame_sinks/frame_evictor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698