ios/chrome/browser/tabs/tab.mm - Issue 2811073005: Replace requirePageReconstruction with setCustomUserAgent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/tabs/tab.mm

Issue 2811073005: Replace requirePageReconstruction with setCustomUserAgent (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/tabs/tab.mm

diff --git a/ios/chrome/browser/tabs/tab.mm b/ios/chrome/browser/tabs/tab.mm

index 29e6c97cf7639d70992406f2fda3314575ef1aa7..132396c86b5ea1ec747ce85632491555f9bb3210 100644

--- a/ios/chrome/browser/tabs/tab.mm

+++ b/ios/chrome/browser/tabs/tab.mm

@@ -1368,9 +1368,6 @@ - (BOOL)usesDesktopUserAgent {

}

- (void)reloadWithUserAgentType:(web::UserAgentType)userAgentType {

- // This removes the web view, which will be recreated at the end of this.

- [self.webController requirePageReconstruction];

Eugene But (OOO till 7-30) 2017/04/12 18:22:02 Cool. Can you make this method private for CRWWebC

liaoyuke 2017/04/12 19:17:59 Done.

// TODO(crbug.com/228171): A hack in session_controller -addPendingItem

// discusses making tab responsible for distinguishing history stack

// navigation from new navigations.