Replace requirePageReconstruction with setCustomUserAgent

ios/web/web_state/ui/crw_web_controller.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/web/web_state/ui/crw_web_controller.h"
 
 #import <WebKit/WebKit.h>
 
 #import <objc/runtime.h>
 #include <stddef.h>
@@ skipping 441 matching lines @@
 // an error if the returned URL is not reliable from a security point of view.
 // Note that this method is expensive, so it should always be cached locally if
 // it's needed multiple times in a method.
 @property(nonatomic, readonly) GURL currentURL;
 // Returns the referrer for the current page.
 @property(nonatomic, readonly) web::Referrer currentReferrer;
 
 // Returns YES if the user interacted with the page recently.
 @property(nonatomic, readonly) BOOL userClickedRecently;
 
-// Whether or not desktop user agent is used for the currentItem.
-@property(nonatomic, readonly) BOOL usesDesktopUserAgent;
+// User agent type of the transient item if any, the pending item if a
+// navigation is in progress or the last committed item otherwise.
+// Returns MOBILE, the default type, if navigation manager is nullptr or empty.
+@property(nonatomic, readonly) web::UserAgentType userAgentType;
 
 // Facade for Mojo API.
 @property(nonatomic, readonly) web::MojoFacade* mojoFacade;
 
 // TODO(crbug.com/692871): Remove these functions and replace with more
 // appropriate NavigationItem getters.
 // Returns the navigation item for the current page.
 @property(nonatomic, readonly) web::NavigationItemImpl* currentNavItem;
 // Returns the current transition type.
 @property(nonatomic, readonly) ui::PageTransition currentTransition;
 // Returns the referrer for current navigation item. May be empty.
 @property(nonatomic, readonly) web::Referrer currentNavItemReferrer;
 // The HTTP headers associated with the current navigation item. These are nil
 // unless the request was a POST.
 @property(nonatomic, readonly) NSDictionary* currentHTTPHeaders;
 
-// Requires page reconstruction if |item| has a non-NONE UserAgentType and it
-// differs from that of |fromItem|.
-- (void)updateDesktopUserAgentForItem:(web::NavigationItem*)item
-                previousUserAgentType:(web::UserAgentType)userAgentType;
+// Updates the user agent used to make HTTP request if |item|'s user agent type
+// is not NONE and has changed.
+- (void)updateUserAgentForItem:(web::NavigationItem*)item

[Eugene But (OOO till 7-30), 2017/04/12 18:22:02]

updateWebViewUserAgentFromItem: ?

[liaoyuke, 2017/04/12 19:17:59]

Thanks! that's even better, and after looking at the caller place, I think it
makes more sense to pass in two items instead of an item and a user agent type.

+         previousUserAgentType:(web::UserAgentType)previousUserAgentType;
 
 // Removes the container view from the hierarchy and resets the ivar.
 - (void)resetContainerView;
 // Called when the web page has changed document and/or URL, and so the page
 // navigation should be reported to the delegate, and internal state updated to
 // reflect the fact that the navigation has occurred.
 // TODO(stuartmorgan): The code conflates URL changes and document object
 // changes; the two need to be separated and handled differently.
 - (void)webPageChanged;
 // Resets any state that is associated with a specific document object (e.g.,
@@ skipping 1115 matching lines @@
     [self didFinishWithURL:targetURL loadSuccess:NO];
     return;
   }
 
   // JavaScript should never be evaluated here. User-entered JS should be
   // evaluated via stringByEvaluatingUserJavaScriptFromString.
   DCHECK(!targetURL.SchemeIs(url::kJavaScriptScheme));
 
   [self ensureWebViewCreated];
 
+  NSString* userAgent = base::SysUTF8ToNSString(
+      web::GetWebClient()->GetUserAgent(self.userAgentType));
+  [_webView setCustomUserAgent:userAgent];

[Eugene But (OOO till 7-30), 2017/04/12 18:22:02]

Are there any performance implications in calling this for every load? This call
can potentially send a message to a separate process.

[liaoyuke, 2017/04/12 19:17:59]

That is a very good question. I'm not sure how WKWebView works, is it no-op if
|userAgent| is the same as WKWebView's current user agent?

Calling this for every load is simple and clean, so as long as [_webView
setCustomUserAgent:userAgent]; is not causing any noticeable delay, I think it
worths the overhead, WDYT?

[Eugene But (OOO till 7-30), 2017/04/13 00:34:06]

WKWebView code is open source, so it should not be hard to check.

[liaoyuke, 2017/04/13 23:03:53]

Sorry, forgot to reply. I was only able to find the header file of WKWebView,
but not source file, so I still don't know if there is performance implications.

[Eugene But (OOO till 7-30), 2017/04/14 00:19:53]

WKWebView source code:
https://trac.webkit.org/browser/webkit/trunk/Source/WebKit2/UIProcess/API/Cocoa

More info on WebKit:
https://webkit.org/getting-the-code/

+
   [self loadRequestForCurrentNavigationItem];
 }
 
 - (void)updatePendingNavigationInfoFromNavigationAction:
     (WKNavigationAction*)action {
   if (action.targetFrame.mainFrame) {
     _pendingNavigationInfo.reset(
         [[CRWWebControllerPendingNavigationInfo alloc] init]);
     [_pendingNavigationInfo
         setReferrer:[self referrerFromNavigationAction:action]];
@@ skipping 394 matching lines @@
     [self recordStateInHistory];
 
   [self clearTransientContentView];
 
   // Update the user agent before attempting the navigation.
   web::NavigationItem* toItem = items[index].get();
   web::NavigationItem* previousItem = sessionController.currentItem;
   web::UserAgentType previousUserAgentType =
       previousItem ? previousItem->GetUserAgentType()
                    : web::UserAgentType::NONE;
-  [self updateDesktopUserAgentForItem:toItem
-                previousUserAgentType:previousUserAgentType];
+  [self updateUserAgentForItem:toItem
+         previousUserAgentType:previousUserAgentType];
 
   BOOL sameDocumentNavigation =
       [sessionController isSameDocumentNavigationBetweenItem:previousItem
                                                      andItem:toItem];
   if (sameDocumentNavigation) {
     [sessionController goToItemAtIndex:index];
     [self updateHTML5HistoryState];
   } else {
     [sessionController discardNonCommittedItems];
     [sessionController setPendingItemIndex:index];
@@ skipping 137 matching lines @@
   // The page should be closed if it was initiated by the DOM and there has been
   // no user interaction with the page since the web view was created, or if
   // the page has no navigation items, as occurs when an App Store link is
   // opened from another application.
   BOOL rendererInitiatedWithoutInteraction =
       self.hasOpener && !_userInteractedWithWebController;
   BOOL noNavigationItems = !(self.navigationManagerImpl->GetItemCount());
   return rendererInitiatedWithoutInteraction || noNavigationItems;
 }
 
-- (BOOL)usesDesktopUserAgent {
-  web::NavigationItem* item = self.currentNavItem;
-  return item && item->GetUserAgentType() == web::UserAgentType::DESKTOP;
+- (web::UserAgentType)userAgentType {
+  if (!self.currentNavItem)

[Eugene But (OOO till 7-30), 2017/04/12 18:22:02]

Old code with ternary could be faster

[liaoyuke, 2017/04/12 19:17:59]

Done.

+    return web::UserAgentType::MOBILE;
+
+  return self.currentNavItem->GetUserAgentType();
 }
 
 - (web::MojoFacade*)mojoFacade {
   if (!_mojoFacade) {
     service_manager::mojom::InterfaceProvider* interfaceProvider =
         _webStateImpl->GetMojoInterfaceRegistry();
     _mojoFacade.reset(new web::MojoFacade(interfaceProvider, self));
   }
   return _mojoFacade.get();
 }
@@ skipping 18 matching lines @@
       [delegate webController:strongSelf didLoadPassKitObject:data];
     }
   };
   web::BrowserState* browserState = self.webStateImpl->GetBrowserState();
   _passKitDownloader.reset([[CRWPassKitDownloader alloc]
       initWithContextGetter:browserState->GetRequestContext()
           completionHandler:passKitCompletion]);
   return _passKitDownloader.get();
 }
 
-- (void)updateDesktopUserAgentForItem:(web::NavigationItem*)item
-                previousUserAgentType:(web::UserAgentType)userAgentType {
+- (void)updateUserAgentForItem:(web::NavigationItem*)item
+         previousUserAgentType:(web::UserAgentType)previousUserAgentType {
   if (!item)
     return;
-  web::UserAgentType itemUserAgentType = item->GetUserAgentType();
-  if (itemUserAgentType == web::UserAgentType::NONE)
+  web::UserAgentType currentUserAgentType = item->GetUserAgentType();

[Eugene But (OOO till 7-30), 2017/04/12 18:22:02]

This isn't "current", right? Current is one that is used in WKWebView.

[liaoyuke, 2017/04/12 19:17:59]

Done.

+  if (currentUserAgentType == web::UserAgentType::NONE)
     return;
-  if (itemUserAgentType != userAgentType)
-    [self requirePageReconstruction];
+
+  if (currentUserAgentType != previousUserAgentType) {
+    NSString* currentUserAgent = base::SysUTF8ToNSString(

[Eugene But (OOO till 7-30), 2017/04/12 18:22:02]

ditto

[liaoyuke, 2017/04/12 19:17:59]

Done.

+        web::GetWebClient()->GetUserAgent(currentUserAgentType));
+    [_webView setCustomUserAgent:currentUserAgent];
+  }
 }
 
 #pragma mark -
 #pragma mark CRWWebControllerContainerViewDelegate
 
 - (CRWWebViewProxyImpl*)contentViewProxyForContainerView:
         (CRWWebControllerContainerView*)containerView {
   return _webViewProxy.get();
 }
 
@@ skipping 1781 matching lines @@
                                             scrollView:self.webScrollView]);
     [_containerView displayWebViewContentView:webViewContentView];
   }
 }
 
 - (WKWebView*)webViewWithConfiguration:(WKWebViewConfiguration*)config {
   // Do not attach the context menu controller immediately as the JavaScript
   // delegate must be specified.
   return web::BuildWKWebView(CGRectZero, config,
                              self.webStateImpl->GetBrowserState(),
-                             self.usesDesktopUserAgent);
+                             self.userAgentType);
 }
 
 - (void)setWebView:(WKWebView*)webView {
   DCHECK_NE(_webView.get(), webView);
 
   // Unwind the old web view.
   // TODO(eugenebut): Remove CRWWKScriptMessageRouter once crbug.com/543374 is
   // fixed.
   CRWWKScriptMessageRouter* messageRouter =
       [self webViewConfigurationProvider].GetScriptMessageRouter();
@@ skipping 1016 matching lines @@
 - (void)simulateLoadRequestWithURL:(const GURL&)URL {
   _lastRegisteredRequestURL = URL;
   _loadPhase = web::LOAD_REQUESTED;
 }
 
 - (NSString*)referrerFromNavigationAction:(WKNavigationAction*)action {
   return [action.request valueForHTTPHeaderField:kReferrerHeaderName];
 }
 
 @end