Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: src/code-stub-assembler.cc

Issue 2811063003: [regexp] Address various minor nits (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/builtins/builtins-regexp-gen.cc ('K') | « src/builtins/builtins-regexp-gen.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stub-assembler.cc
diff --git a/src/code-stub-assembler.cc b/src/code-stub-assembler.cc
index 03c80d2ed424cf755e3da7f93648f23b53ba36eb..fb0ffc9b39456e63a5515a926c242e6821373d32 100644
--- a/src/code-stub-assembler.cc
+++ b/src/code-stub-assembler.cc
@@ -3154,10 +3154,12 @@ Node* CodeStubAssembler::IsJSRegExp(Node* object) {
Node* CodeStubAssembler::StringCharCodeAt(Node* string, Node* index,
ParameterMode parameter_mode) {
+ if (parameter_mode == SMI_PARAMETERS) CSA_ASSERT(this, TaggedIsSmi(index));
CSA_ASSERT(this, IsString(string));
// Translate the {index} into a Word.
Node* const int_index = ParameterToWord(index, parameter_mode);
+ CSA_ASSERT(this, IntPtrGreaterThanOrEqual(int_index, IntPtrConstant(0)));
VARIABLE(var_result, MachineRepresentation::kWord32);
« src/builtins/builtins-regexp-gen.cc ('K') | « src/builtins/builtins-regexp-gen.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698