Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp

Issue 2811063002: Enable ServiceWorkerNavigationPreload by default (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp
diff --git a/third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp b/third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp
index 29d83a97abc88c4bcf4a79b6e7b383d8498070bc..f26d82f34d22f0813087d145d2e4b45b9d57fccb 100644
--- a/third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp
+++ b/third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp
@@ -13,13 +13,11 @@
#include "bindings/core/v8/V8Window.h"
#include "bindings/core/v8/V8WorkerNavigator.h"
#include "bindings/modules/v8/V8DedicatedWorkerGlobalScopePartial.h"
-#include "bindings/modules/v8/V8FetchEvent.h"
#include "bindings/modules/v8/V8Gamepad.h"
#include "bindings/modules/v8/V8GamepadButton.h"
#include "bindings/modules/v8/V8InstallEvent.h"
#include "bindings/modules/v8/V8NavigatorPartial.h"
#include "bindings/modules/v8/V8ServiceWorkerGlobalScope.h"
-#include "bindings/modules/v8/V8ServiceWorkerRegistration.h"
#include "bindings/modules/v8/V8SharedWorkerGlobalScopePartial.h"
#include "bindings/modules/v8/V8WindowPartial.h"
#include "bindings/modules/v8/V8WorkerNavigatorPartial.h"
@@ -94,30 +92,6 @@ void InstallConditionalFeaturesForModules(
V8WindowPartial::installGamepadExtensions(
isolate, world, instance_object, prototype_object, interface_object);
}
- if (OriginTrials::serviceWorkerNavigationPreloadEnabled(
- execution_context)) {
- V8WindowPartial::installServiceWorkerNavigationPreload(
- isolate, world, instance_object, prototype_object, interface_object);
- }
- } else if (wrapper_type_info ==
- &V8DedicatedWorkerGlobalScope::wrapperTypeInfo) {
- v8::Local<v8::Object> instance_object =
- script_state->GetContext()->Global();
- if (OriginTrials::serviceWorkerNavigationPreloadEnabled(
- execution_context)) {
- V8DedicatedWorkerGlobalScopePartial::
- installServiceWorkerNavigationPreload(isolate, world, instance_object,
- prototype_object,
- interface_object);
- }
- } else if (wrapper_type_info == &V8SharedWorkerGlobalScope::wrapperTypeInfo) {
- v8::Local<v8::Object> instance_object =
- script_state->GetContext()->Global();
- if (OriginTrials::serviceWorkerNavigationPreloadEnabled(
- execution_context)) {
- V8SharedWorkerGlobalScopePartial::installServiceWorkerNavigationPreload(
- isolate, world, instance_object, prototype_object, interface_object);
- }
} else if (wrapper_type_info ==
&V8ServiceWorkerGlobalScope::wrapperTypeInfo) {
v8::Local<v8::Object> instance_object =
@@ -126,26 +100,6 @@ void InstallConditionalFeaturesForModules(
V8ServiceWorkerGlobalScope::installForeignFetch(
isolate, world, instance_object, prototype_object, interface_object);
}
- if (OriginTrials::serviceWorkerNavigationPreloadEnabled(
- execution_context)) {
- V8ServiceWorkerGlobalScope::installServiceWorkerNavigationPreload(
- isolate, world, instance_object, prototype_object, interface_object);
- }
- } else if (wrapper_type_info ==
- &V8ServiceWorkerRegistration::wrapperTypeInfo) {
- if (OriginTrials::serviceWorkerNavigationPreloadEnabled(
- execution_context)) {
- V8ServiceWorkerRegistration::installServiceWorkerNavigationPreload(
- isolate, world, v8::Local<v8::Object>(), prototype_object,
- interface_object);
- }
- } else if (wrapper_type_info == &V8FetchEvent::wrapperTypeInfo) {
- if (OriginTrials::serviceWorkerNavigationPreloadEnabled(
- execution_context)) {
- V8FetchEvent::installServiceWorkerNavigationPreload(
- isolate, world, v8::Local<v8::Object>(), prototype_object,
- interface_object);
- }
} else if (wrapper_type_info == &V8InstallEvent::wrapperTypeInfo) {
if (OriginTrials::foreignFetchEnabled(execution_context)) {
V8InstallEvent::installForeignFetch(isolate, world,
@@ -201,27 +155,6 @@ void InstallPendingConditionalFeatureForModules(
}
return;
}
- if (feature == "ServiceWorkerNavigationPreload") {
- global_instance_object = script_state->GetContext()->Global();
- V8WindowPartial::installServiceWorkerNavigationPreload(
- isolate, world, global_instance_object, v8::Local<v8::Object>(),
- v8::Local<v8::Function>());
- if (context_data->GetExistingConstructorAndPrototypeForType(
- &V8FetchEvent::wrapperTypeInfo, &prototype_object,
- &interface_object)) {
- V8FetchEvent::installServiceWorkerNavigationPreload(
- isolate, world, v8::Local<v8::Object>(), prototype_object,
- interface_object);
- }
- if (context_data->GetExistingConstructorAndPrototypeForType(
- &V8ServiceWorkerRegistration::wrapperTypeInfo, &prototype_object,
- &interface_object)) {
- V8ServiceWorkerRegistration::installServiceWorkerNavigationPreload(
- isolate, world, v8::Local<v8::Object>(), prototype_object,
- interface_object);
- }
- return;
- }
if (feature == "WebShare") {
if (context_data->GetExistingConstructorAndPrototypeForType(
&V8Navigator::wrapperTypeInfo, &prototype_object,

Powered by Google App Engine
This is Rietveld 408576698