Chromium Code Reviews
Help | Chromium Project | Sign in
(59)

Issue 2811059: AutoFill: Limit the size of form field data allowed to be saved in WebData as a (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by James Hawkins
Modified:
4 years ago
Reviewers:
dhollowa
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

AutoFill: Limit the size of form field data allowed to be saved in WebData as a temporary workaround to prevent DOS'ing the browser with large profile data. BUG=49172 TEST=WebDatabase.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53130

Patch Set 1 #

Total comments: 2

Patch Set 2 : Indentation fixes. #

Patch Set 3 : PBR. #

Patch Set 4 : PBR fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -204 lines) Patch
M chrome/browser/webdata/web_database.cc View 1 2 3 8 chunks +219 lines, -204 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
James Hawkins
4 years, 10 months ago (2010-07-20 23:31:06 UTC) #1
dhollowa
LGTM, small nit. http://codereview.chromium.org/2811059/diff/1/2 File chrome/browser/webdata/web_database.cc (right): http://codereview.chromium.org/2811059/diff/1/2#newcode215 chrome/browser/webdata/web_database.cc:215: sql::Statement* s) { nit: Indentation. (And ...
4 years, 10 months ago (2010-07-20 23:44:30 UTC) #2
James Hawkins
4 years, 10 months ago (2010-07-20 23:48:13 UTC) #3
http://codereview.chromium.org/2811059/diff/1/2
File chrome/browser/webdata/web_database.cc (right):

http://codereview.chromium.org/2811059/diff/1/2#newcode215
chrome/browser/webdata/web_database.cc:215: sql::Statement* s) {
On 2010/07/20 23:44:31, dhollowa wrote:
> nit: Indentation.  (And below).

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be