Issue 2811059: AutoFill: Limit the size of form field data allowed to be saved in WebData as a

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2811059: AutoFill: Limit the size of form field data allowed to be saved in WebData as a (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by James Hawkins

Modified:
4 years ago

Reviewers:
dhollowa

CC:
chromium-reviews, ben+cc_chromium.org

Visibility:
Public.

Description

AutoFill: Limit the size of form field data allowed to be saved in WebData as a temporary workaround to prevent DOS'ing the browser with large profile data. BUG=49172 TEST=WebDatabase.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53130

Patch Set 1 #

Total comments: 2

Patch Set 2 : Indentation fixes. #

Patch Set 3 : PBR. #

Patch Set 4 : PBR fix. #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+219 lines, -204 lines)			Patch
	M	chrome/browser/webdata/web_database.cc	View	1 2 3	8 chunks	+219 lines, -204 lines	0 comments	Download

Trybot results:

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dhollowa

LGTM, small nit. http://codereview.chromium.org/2811059/diff/1/2 File chrome/browser/webdata/web_database.cc (right): http://codereview.chromium.org/2811059/diff/1/2#newcode215 chrome/browser/webdata/web_database.cc:215: sql::Statement* s) { nit: Indentation. (And ...

4 years, 10 months ago (2010-07-20 23:44:30 UTC) #2

James Hawkins

4 years, 10 months ago (2010-07-20 23:48:13 UTC) #3

http://codereview.chromium.org/2811059/diff/1/2
File chrome/browser/webdata/web_database.cc (right):

http://codereview.chromium.org/2811059/diff/1/2#newcode215
chrome/browser/webdata/web_database.cc:215: sql::Statement* s) {
On 2010/07/20 23:44:31, dhollowa wrote:
> nit: Indentation.  (And below).

Done.

Expand Messages | Collapse Messages