Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 2811029: utility: add a simple tool for dumping the kernel config (Closed)

Created:
10 years, 6 months ago by Will Drewry
Modified:
9 years, 7 months ago
Reviewers:
Bill Richardson
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://git@gitrw.chromium.org//vboot_reference.git
Visibility:
Public.

Description

utility: add a simple tool for dumping the kernel config Adds dump_kernel_config.c which takes in a file, reads it all in to memory, then walks the blob until it can determine the location of the kernel command line. This is needed to allow the kernel config to inform legacy bootloader configuration during autoupdates without packaging up dm-verity specific options in some additional update metadata. TEST=manual run over build_kernel_image.sh output BUG=chromium-os:327

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix for wfrichar's comments #

Patch Set 3 : more header cleanup #

Patch Set 4 : clean up offsets #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -0 lines) Patch
M utility/Makefile View 2 chunks +4 lines, -0 lines 0 comments Download
A utility/dump_kernel_config.c View 1 2 3 1 chunk +135 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Will Drewry
10 years, 6 months ago (2010-06-24 18:05:22 UTC) #1
Bill Richardson
A couple of comments. You'll also have to make changes to the ebuild to ensure ...
10 years, 6 months ago (2010-06-24 18:33:40 UTC) #2
Will Drewry
http://codereview.chromium.org/2811029/diff/1/3 File utility/dump_kernel_config.c (right): http://codereview.chromium.org/2811029/diff/1/3#newcode16 utility/dump_kernel_config.c:16: #include "host_common.h" On 2010/06/24 18:33:40, Bill Richardson wrote: > ...
10 years, 6 months ago (2010-06-25 03:15:28 UTC) #3
Bill Richardson
10 years, 6 months ago (2010-06-25 14:04:42 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698