Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Side by Side Diff: chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.cc

Issue 2810973004: Revert of Fetch ARC Kiosk app name and icon from Android side. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.h" 5 #include "chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <utility> 9 #include <utility>
10 10
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 .GetImageNamed(IDR_APP_DEFAULT_ICON) 122 .GetImageNamed(IDR_APP_DEFAULT_ICON)
123 .ToSkBitmap()); 123 .ToSkBitmap());
124 } else { 124 } else {
125 icon_url = webui::GetBitmapDataUrl(*app_data.icon.bitmap()); 125 icon_url = webui::GetBitmapDataUrl(*app_data.icon.bitmap());
126 } 126 }
127 app_info->SetString("iconUrl", icon_url); 127 app_info->SetString("iconUrl", icon_url);
128 128
129 apps_list.Append(std::move(app_info)); 129 apps_list.Append(std::move(app_info));
130 } 130 }
131 131
132 ArcKioskAppManager::Apps arc_apps; 132 const auto& arc_apps = ArcKioskAppManager::Get()->GetAllApps();
133 ArcKioskAppManager::Get()->GetAllApps(&arc_apps);
134 for (size_t i = 0; i < arc_apps.size(); ++i) { 133 for (size_t i = 0; i < arc_apps.size(); ++i) {
135 std::unique_ptr<base::DictionaryValue> app_info( 134 std::unique_ptr<base::DictionaryValue> app_info(
136 new base::DictionaryValue()); 135 new base::DictionaryValue());
137 app_info->SetBoolean("isApp", true); 136 app_info->SetBoolean("isApp", true);
138 app_info->SetBoolean("isAndroidApp", true); 137 app_info->SetBoolean("isAndroidApp", true);
139 app_info->SetString("id", arc_apps[i]->app_id()); 138 app_info->SetString("id", arc_apps[i].app_info().package_name());
140 app_info->SetString("account_email", 139 app_info->SetString("account_email",
141 arc_apps[i]->account_id().GetUserEmail()); 140 arc_apps[i].account_id().GetUserEmail());
142 app_info->SetString("label", arc_apps[i]->name()); 141 app_info->SetString("label", arc_apps[i].name());
143 142
144 std::string icon_url; 143 std::string icon_url =
145 if (arc_apps[i]->icon().isNull()) { 144 webui::GetBitmapDataUrl(*ResourceBundle::GetSharedInstance()
146 icon_url = 145 .GetImageNamed(IDR_APP_DEFAULT_ICON)
147 webui::GetBitmapDataUrl(*ResourceBundle::GetSharedInstance() 146 .ToSkBitmap());
148 .GetImageNamed(IDR_APP_DEFAULT_ICON)
149 .ToSkBitmap());
150 } else {
151 icon_url = webui::GetBitmapDataUrl(*arc_apps[i]->icon().bitmap());
152 }
153 app_info->SetString("iconUrl", icon_url); 147 app_info->SetString("iconUrl", icon_url);
154 148
155 apps_list.Append(std::move(app_info)); 149 apps_list.Append(std::move(app_info));
156 } 150 }
157 151
158 web_ui()->CallJavascriptFunctionUnsafe( 152 web_ui()->CallJavascriptFunctionUnsafe(
159 EnableNewKioskUI() ? kKioskSetAppsNewAPI : kKioskSetAppsOldAPI, 153 EnableNewKioskUI() ? kKioskSetAppsNewAPI : kKioskSetAppsOldAPI,
160 apps_list); 154 apps_list);
161 } 155 }
162 156
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 void KioskAppMenuHandler::UpdateState(NetworkError::ErrorReason reason) { 198 void KioskAppMenuHandler::UpdateState(NetworkError::ErrorReason reason) {
205 if (network_state_informer_->state() == NetworkStateInformer::ONLINE) 199 if (network_state_informer_->state() == NetworkStateInformer::ONLINE)
206 KioskAppManager::Get()->RetryFailedAppDataFetch(); 200 KioskAppManager::Get()->RetryFailedAppDataFetch();
207 } 201 }
208 202
209 void KioskAppMenuHandler::OnArcKioskAppsChanged() { 203 void KioskAppMenuHandler::OnArcKioskAppsChanged() {
210 SendKioskApps(); 204 SendKioskApps();
211 } 205 }
212 206
213 } // namespace chromeos 207 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698