[heap] Implement simple concurrent marking deque.

test/cctest/heap/test-mark-compact.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 23 matching lines @@
 #include <sys/types.h>
 #include <unistd.h>
 #endif
 
 #include <utility>
 
 #include "src/v8.h"
 
 #include "src/full-codegen/full-codegen.h"
 #include "src/global-handles.h"
+#include "src/heap/concurrent-marking-deque.h"
 #include "src/heap/mark-compact-inl.h"
 #include "src/heap/mark-compact.h"
+#include "src/heap/sequential-marking-deque.h"
 #include "src/objects-inl.h"
 #include "test/cctest/cctest.h"
 #include "test/cctest/heap/heap-tester.h"
 #include "test/cctest/heap/heap-utils.h"
 
 using namespace v8::internal;
 using v8::Just;
 
+TEST(ConcurrentMarkingDeque) {

[Michael Lippautz, 2017/05/02 09:39:31]

nit: Could be a unit test.

[ulan, 2017/05/02 13:19:53]

Done. Converted it to unit test.

+  CcTest::InitializeVM();
+  Isolate* isolate = CcTest::i_isolate();
+  ConcurrentMarkingDeque marking_deque(isolate->heap());
+  v8::HandleScope sc(CcTest::isolate());
+  Handle<FixedArray> object = isolate->factory()->NewFixedArray(10);
+  marking_deque.Push(*object);
+  CHECK(!marking_deque.IsEmpty());
+  CHECK_EQ(1, marking_deque.Size());
+  CHECK_EQ(*object, marking_deque.Pop(MarkingThread::kConcurrent));
+  CHECK(marking_deque.IsEmpty());
+  marking_deque.Push(*object, MarkingThread::kConcurrent,
+                     TargetDeque::kBailout);
+  CHECK(!marking_deque.IsEmpty());
+  CHECK_EQ(1, marking_deque.Size());
+  CHECK(nullptr == marking_deque.Pop(MarkingThread::kConcurrent));
+  CHECK_EQ(*object, marking_deque.Pop());
+  CHECK(nullptr == marking_deque.Pop());
+}
 
-TEST(MarkingDeque) {
+TEST(SequentialMarkingDeque) {

[Michael Lippautz, 2017/05/02 09:39:31]

nit: Similarly, this could also be a unit test.

[ulan, 2017/05/02 13:19:53]

I am keeping it here because it depends on cancelable tasks and will be removed
in future anyway.

   CcTest::InitializeVM();
-  MarkingDeque s(CcTest::i_isolate()->heap());
+  SequentialMarkingDeque s(CcTest::i_isolate()->heap());
   s.SetUp();
   s.StartUsing();
   Address original_address = reinterpret_cast<Address>(&s);
   Address current_address = original_address;
   while (!s.IsFull()) {
     s.Push(HeapObject::FromAddress(current_address));
     current_address += kPointerSize;
   }
 
   while (!s.IsEmpty()) {
@@ skipping 288 matching lines @@
   heap->old_space()->EmptyAllocationInfo();
   Page* page = Page::FromAddress(array->address());
   LiveObjectIterator<kGreyObjects> it(page, MarkingState::Internal(page));
   HeapObject* object = nullptr;
   while ((object = it.Next()) != nullptr) {
     CHECK(!object->IsFiller());
   }
 }
 
 #endif  // __linux__ and !USE_SIMULATOR