Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3284)

Unified Diff: base/task_scheduler/task_scheduler_impl.h

Issue 2810873008: Separate the create and start phases in DelayedTaskManager. (Closed)
Patch Set: CR-gab-11 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task_scheduler/task_scheduler_impl.h
diff --git a/base/task_scheduler/task_scheduler_impl.h b/base/task_scheduler/task_scheduler_impl.h
index 83783c6ffdb034ca6f77c331b7ed0287ab80c4cd..276415923cc79f1a2b0e2dbe6d4247c2a5b04ea8 100644
--- a/base/task_scheduler/task_scheduler_impl.h
+++ b/base/task_scheduler/task_scheduler_impl.h
@@ -14,6 +14,8 @@
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "base/synchronization/atomic_flag.h"
+#include "base/task_scheduler/delayed_task_manager.h"
+#include "base/task_scheduler/scheduler_single_thread_task_runner_manager.h"
#include "base/task_scheduler/scheduler_worker_pool_impl.h"
#include "base/task_scheduler/sequence.h"
#include "base/task_scheduler/task_scheduler.h"
@@ -32,9 +34,6 @@ class HistogramBase;
namespace internal {
-class DelayedTaskManager;
-class SchedulerSingleThreadTaskRunnerManager;
-
// Default TaskScheduler implementation. This class is thread-safe.
class BASE_EXPORT TaskSchedulerImpl : public TaskScheduler {
public:
@@ -93,9 +92,8 @@ class BASE_EXPORT TaskSchedulerImpl : public TaskScheduler {
#else
TaskTracker task_tracker_;
#endif
- std::unique_ptr<DelayedTaskManager> delayed_task_manager_;
- std::unique_ptr<SchedulerSingleThreadTaskRunnerManager>
- single_thread_task_runner_manager_;
+ DelayedTaskManager delayed_task_manager_;
+ SchedulerSingleThreadTaskRunnerManager single_thread_task_runner_manager_;
// There are 4 SchedulerWorkerPoolImpl in this array to match the 4
// SchedulerWorkerPoolParams in TaskScheduler::InitParams.

Powered by Google App Engine
This is Rietveld 408576698