Separate the create and start phases in DelayedTaskManager.

base/task_scheduler/scheduler_single_thread_task_runner_manager_unittest.cc

Index: base/task_scheduler/scheduler_single_thread_task_runner_manager_unittest.cc
diff --git a/base/task_scheduler/scheduler_single_thread_task_runner_manager_unittest.cc b/base/task_scheduler/scheduler_single_thread_task_runner_manager_unittest.cc
index 17333e9f419e4b029787ddfbb2fc2a1676c1b6c9..4cc0438d8e19615af5e3469abd4bcf8be997d575 100644
--- a/base/task_scheduler/scheduler_single_thread_task_runner_manager_unittest.cc
+++ b/base/task_scheduler/scheduler_single_thread_task_runner_manager_unittest.cc
@@ -39,17 +39,15 @@ class TaskSchedulerSingleThreadTaskRunnerManagerTest : public testing::Test {
 
   void SetUp() override {
     service_thread_.Start();
-    delayed_task_manager_ =
-        MakeUnique<DelayedTaskManager>(service_thread_.task_runner());
+    delayed_task_manager_.Start(service_thread_.task_runner());
     single_thread_task_runner_manager_ =
         MakeUnique<SchedulerSingleThreadTaskRunnerManager>(
-            &task_tracker_, delayed_task_manager_.get());
+            &task_tracker_, &delayed_task_manager_);

[robliao, 2017/04/12 19:23:23]

Now that I see the operator& usage, I think we should keep to using .get() for
smart pointers when we simply want to get the pointer.

Using operator& makes it look like we can mutate the pointer instance. .get() at
least is const.

[fdoray, 2017/04/13 12:03:53]

|delayed_task_manager_| is no longer a std::unique_ptr. Can't use .get().

[robliao, 2017/04/17 18:35:37]

Ah, right you are. Missed that.

     StartSingleThreadTaskRunnerManagerFromSetup();
   }
 
   void TearDown() override {
     TearDownSingleThreadTaskRunnerManager();
-    delayed_task_manager_.reset();
     service_thread_.Stop();
   }
 
@@ -69,7 +67,7 @@ class TaskSchedulerSingleThreadTaskRunnerManagerTest : public testing::Test {
 
  private:
   Thread service_thread_;
-  std::unique_ptr<DelayedTaskManager> delayed_task_manager_;
+  DelayedTaskManager delayed_task_manager_;
 
   DISALLOW_COPY_AND_ASSIGN(TaskSchedulerSingleThreadTaskRunnerManagerTest);
 };