Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: base/task_scheduler/scheduler_single_thread_task_runner_manager_unittest.cc

Issue 2810873008: Separate the create and start phases in DelayedTaskManager. (Closed)
Patch Set: self-review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task_scheduler/scheduler_single_thread_task_runner_manager_unittest.cc
diff --git a/base/task_scheduler/scheduler_single_thread_task_runner_manager_unittest.cc b/base/task_scheduler/scheduler_single_thread_task_runner_manager_unittest.cc
index f7510a0ad48c8f7785a4b50c3f518fc4b6b8dbb3..7ff0c9d0a2709353f8407b91614b4da6c4c02678 100644
--- a/base/task_scheduler/scheduler_single_thread_task_runner_manager_unittest.cc
+++ b/base/task_scheduler/scheduler_single_thread_task_runner_manager_unittest.cc
@@ -39,17 +39,15 @@ class TaskSchedulerSingleThreadTaskRunnerManagerTest : public testing::Test {
void SetUp() override {
service_thread_.Start();
- delayed_task_manager_ =
- MakeUnique<DelayedTaskManager>(service_thread_.task_runner());
+ delayed_task_manager_.Start(service_thread_.task_runner());
single_thread_task_runner_manager_ =
MakeUnique<SchedulerSingleThreadTaskRunnerManager>(
- &task_tracker_, delayed_task_manager_.get());
+ &task_tracker_, &delayed_task_manager_);
StartSingleThreadTaskRunnerManagerFromSetUp();
}
void TearDown() override {
TearDownSingleThreadTaskRunnerManager();
- delayed_task_manager_.reset();
service_thread_.Stop();
}
@@ -69,7 +67,7 @@ class TaskSchedulerSingleThreadTaskRunnerManagerTest : public testing::Test {
private:
Thread service_thread_;
- std::unique_ptr<DelayedTaskManager> delayed_task_manager_;
+ DelayedTaskManager delayed_task_manager_;
DISALLOW_COPY_AND_ASSIGN(TaskSchedulerSingleThreadTaskRunnerManagerTest);
};
« no previous file with comments | « base/task_scheduler/delayed_task_manager_unittest.cc ('k') | base/task_scheduler/scheduler_worker_pool_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698