OLD | NEW |
---|---|
1 // Copyright 2016 The Chromium Authors. All rights reserved. | 1 // Copyright 2016 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "base/task_scheduler/delayed_task_manager.h" | 5 #include "base/task_scheduler/delayed_task_manager.h" |
6 | 6 |
7 #include <memory> | 7 #include <memory> |
8 #include <utility> | 8 #include <utility> |
9 | 9 |
10 #include "base/bind.h" | 10 #include "base/bind.h" |
(...skipping 24 matching lines...) Expand all Loading... | |
35 DoPostTaskNowCallback(task.get()); | 35 DoPostTaskNowCallback(task.get()); |
36 } | 36 } |
37 | 37 |
38 private: | 38 private: |
39 DISALLOW_COPY_AND_ASSIGN(MockTaskTarget); | 39 DISALLOW_COPY_AND_ASSIGN(MockTaskTarget); |
40 }; | 40 }; |
41 | 41 |
42 class TaskSchedulerDelayedTaskManagerTest : public testing::Test { | 42 class TaskSchedulerDelayedTaskManagerTest : public testing::Test { |
43 public: | 43 public: |
44 TaskSchedulerDelayedTaskManagerTest() | 44 TaskSchedulerDelayedTaskManagerTest() |
45 : service_thread_task_runner_(new TestMockTimeTaskRunner), | 45 : delayed_task_manager_(service_thread_task_runner_->GetMockTickClock()) { |
46 delayed_task_manager_(service_thread_task_runner_) {} | 46 } |
47 ~TaskSchedulerDelayedTaskManagerTest() override = default; | 47 ~TaskSchedulerDelayedTaskManagerTest() override = default; |
48 | 48 |
49 protected: | 49 protected: |
50 scoped_refptr<TestMockTimeTaskRunner> service_thread_task_runner_; | 50 std::unique_ptr<Task> CreateTask(TimeDelta delay) { |
51 auto task = | |
52 MakeUnique<Task>(FROM_HERE, BindOnce(&DoNothing), TaskTraits(), delay); | |
53 | |
54 // The delayed run time is computed from real time. Use mock time instead. | |
gab
2017/04/19 18:59:17
I think this comment is more confusing than no com
fdoray
2017/04/20 12:08:52
Reworded.
| |
55 task->delayed_run_time = | |
56 service_thread_task_runner_->GetMockTickClock()->NowTicks() + delay; | |
57 | |
58 return task; | |
59 } | |
60 | |
61 testing::StrictMock<MockTaskTarget> task_target_; | |
62 const scoped_refptr<TestMockTimeTaskRunner> service_thread_task_runner_ = | |
63 make_scoped_refptr(new TestMockTimeTaskRunner); | |
51 DelayedTaskManager delayed_task_manager_; | 64 DelayedTaskManager delayed_task_manager_; |
65 std::unique_ptr<Task> task_ = CreateTask(kLongDelay); | |
66 Task* const task_raw_ = task_.get(); | |
52 | 67 |
53 private: | 68 private: |
54 DISALLOW_COPY_AND_ASSIGN(TaskSchedulerDelayedTaskManagerTest); | 69 DISALLOW_COPY_AND_ASSIGN(TaskSchedulerDelayedTaskManagerTest); |
55 }; | 70 }; |
56 | 71 |
57 } // namespace | 72 } // namespace |
58 | 73 |
59 // Verify that a delayed task isn't forwarded before it is ripe for execution. | 74 // Verify that a delayed task isn't forwarded before Start(). |
75 TEST_F(TaskSchedulerDelayedTaskManagerTest, DelayedTaskDoesNotRunBeforeStart) { | |
76 // Send |task| to the DelayedTaskManager. | |
77 delayed_task_manager_.AddDelayedTask( | |
78 std::move(task_), BindOnce(&MockTaskTarget::PostTaskNowCallback, | |
79 Unretained(&task_target_))); | |
80 | |
81 // Fast-forward time until the task is ripe for execution. Since Start() has | |
82 // not been called, the task should be forwarded to |task_target_| | |
83 // (|task_target_| is a StrictMock without expectations, so the test will fail | |
84 // if the task is forwarded to it). | |
85 service_thread_task_runner_->FastForwardBy(kLongDelay); | |
86 } | |
87 | |
88 // Verify that a delayed task added before Start() and whose delay expires after | |
89 // Start() is forwarded when its delay expires. | |
90 TEST_F(TaskSchedulerDelayedTaskManagerTest, | |
91 DelayedTaskPostedBeforeStartExpiresAfterStartRunsOnExpire) { | |
92 // Send |task| to the DelayedTaskManager. | |
93 delayed_task_manager_.AddDelayedTask( | |
94 std::move(task_), BindOnce(&MockTaskTarget::PostTaskNowCallback, | |
95 Unretained(&task_target_))); | |
96 | |
97 delayed_task_manager_.Start(service_thread_task_runner_); | |
98 | |
99 // Run tasks on the service thread. Don't expect any forwarding to | |
100 // |task_target_| since the task isn't ripe for execution. | |
101 service_thread_task_runner_->RunUntilIdle(); | |
102 | |
103 // Fast-forward time until the task is ripe for execution. Expect the task to | |
104 // be forwarded to |task_target_|. | |
105 EXPECT_CALL(task_target_, DoPostTaskNowCallback(task_raw_)); | |
106 service_thread_task_runner_->FastForwardBy(kLongDelay); | |
107 } | |
108 | |
109 // Verify that a delayed task added before Start() and whose delay expires | |
110 // before Start() is forwarded when Start() is called. | |
111 TEST_F(TaskSchedulerDelayedTaskManagerTest, | |
112 DelayedTaskPostedBeforeStartExpiresBeforeStartRunsOnStart) { | |
113 // Send |task| to the DelayedTaskManager. | |
114 delayed_task_manager_.AddDelayedTask( | |
115 std::move(task_), BindOnce(&MockTaskTarget::PostTaskNowCallback, | |
116 Unretained(&task_target_))); | |
117 | |
118 // Run tasks on the service thread. Don't expect any forwarding to | |
119 // |task_target_| since the task isn't ripe for execution. | |
120 service_thread_task_runner_->RunUntilIdle(); | |
121 | |
122 // Fast-forward time until the task is ripe for execution. Don't expect the | |
123 // task to be forwarded since Start() hasn't been called yet. | |
124 service_thread_task_runner_->FastForwardBy(kLongDelay); | |
125 | |
126 // Start the DelayedTaskManager. Expect the task to be forwarded to | |
127 // |task_target_|. | |
128 EXPECT_CALL(task_target_, DoPostTaskNowCallback(task_raw_)); | |
129 delayed_task_manager_.Start(service_thread_task_runner_); | |
130 service_thread_task_runner_->RunUntilIdle(); | |
131 } | |
132 | |
133 // Verify that a delayed task added after Start() isn't forwarded before it is | |
134 // ripe for execution. | |
60 TEST_F(TaskSchedulerDelayedTaskManagerTest, DelayedTaskDoesNotRunTooEarly) { | 135 TEST_F(TaskSchedulerDelayedTaskManagerTest, DelayedTaskDoesNotRunTooEarly) { |
61 auto task = | 136 delayed_task_manager_.Start(service_thread_task_runner_); |
62 MakeUnique<Task>(FROM_HERE, Bind(&DoNothing), TaskTraits(), kLongDelay); | |
63 | |
64 testing::StrictMock<MockTaskTarget> task_target; | |
65 | 137 |
66 // Send |task| to the DelayedTaskManager. | 138 // Send |task| to the DelayedTaskManager. |
67 delayed_task_manager_.AddDelayedTask( | 139 delayed_task_manager_.AddDelayedTask( |
68 std::move(task), | 140 std::move(task_), BindOnce(&MockTaskTarget::PostTaskNowCallback, |
69 Bind(&MockTaskTarget::PostTaskNowCallback, Unretained(&task_target))); | 141 Unretained(&task_target_))); |
70 | 142 |
71 // Run tasks that are ripe for execution. Don't expect any forwarding to | 143 // Run tasks that are ripe for execution. Don't expect any forwarding to |
72 // |task_target|. | 144 // |task_target_|. |
73 service_thread_task_runner_->RunUntilIdle(); | 145 service_thread_task_runner_->RunUntilIdle(); |
74 } | 146 } |
75 | 147 |
76 // Verify that a delayed task is forwarded when it is ripe for execution. | 148 // Verify that a delayed task added after Start() is forwarded when it is ripe |
149 // for execution. | |
77 TEST_F(TaskSchedulerDelayedTaskManagerTest, DelayedTaskRunsAfterDelay) { | 150 TEST_F(TaskSchedulerDelayedTaskManagerTest, DelayedTaskRunsAfterDelay) { |
78 auto task = | 151 delayed_task_manager_.Start(service_thread_task_runner_); |
79 MakeUnique<Task>(FROM_HERE, Bind(&DoNothing), TaskTraits(), kLongDelay); | |
80 const Task* task_raw = task.get(); | |
81 | |
82 testing::StrictMock<MockTaskTarget> task_target; | |
83 | 152 |
84 // Send |task| to the DelayedTaskManager. | 153 // Send |task| to the DelayedTaskManager. |
85 delayed_task_manager_.AddDelayedTask( | 154 delayed_task_manager_.AddDelayedTask( |
86 std::move(task), | 155 std::move(task_), BindOnce(&MockTaskTarget::PostTaskNowCallback, |
87 Bind(&MockTaskTarget::PostTaskNowCallback, Unretained(&task_target))); | 156 Unretained(&task_target_))); |
88 | 157 |
89 // Fast-forward time. Expect the task is forwarded to |task_target|. | 158 // Fast-forward time. Expect the task is forwarded to |task_target_|. |
90 EXPECT_CALL(task_target, DoPostTaskNowCallback(task_raw)); | 159 EXPECT_CALL(task_target_, DoPostTaskNowCallback(task_raw_)); |
91 service_thread_task_runner_->FastForwardBy(kLongDelay); | 160 service_thread_task_runner_->FastForwardBy(kLongDelay); |
92 } | 161 } |
93 | 162 |
94 // Verify that multiple delayed tasks are forwarded when they are ripe for | 163 // Verify that multiple delayed tasks added after Start() are forwarded when |
95 // execution. | 164 // they are ripe for execution. |
96 TEST_F(TaskSchedulerDelayedTaskManagerTest, DelayedTasksRunAfterDelay) { | 165 TEST_F(TaskSchedulerDelayedTaskManagerTest, DelayedTasksRunAfterDelay) { |
97 auto task_a = MakeUnique<Task>(FROM_HERE, Bind(&DoNothing), TaskTraits(), | 166 delayed_task_manager_.Start(service_thread_task_runner_); |
167 auto task_a = MakeUnique<Task>(FROM_HERE, BindOnce(&DoNothing), TaskTraits(), | |
98 TimeDelta::FromHours(1)); | 168 TimeDelta::FromHours(1)); |
99 const Task* task_a_raw = task_a.get(); | 169 const Task* task_a_raw = task_a.get(); |
100 | 170 |
101 auto task_b = MakeUnique<Task>(FROM_HERE, Bind(&DoNothing), TaskTraits(), | 171 auto task_b = MakeUnique<Task>(FROM_HERE, BindOnce(&DoNothing), TaskTraits(), |
102 TimeDelta::FromHours(2)); | 172 TimeDelta::FromHours(2)); |
103 const Task* task_b_raw = task_b.get(); | 173 const Task* task_b_raw = task_b.get(); |
104 | 174 |
105 auto task_c = MakeUnique<Task>(FROM_HERE, Bind(&DoNothing), TaskTraits(), | 175 auto task_c = MakeUnique<Task>(FROM_HERE, BindOnce(&DoNothing), TaskTraits(), |
106 TimeDelta::FromHours(1)); | 176 TimeDelta::FromHours(1)); |
107 const Task* task_c_raw = task_c.get(); | 177 const Task* task_c_raw = task_c.get(); |
108 | 178 |
109 testing::StrictMock<MockTaskTarget> task_target; | |
110 | |
111 // Send tasks to the DelayedTaskManager. | 179 // Send tasks to the DelayedTaskManager. |
112 delayed_task_manager_.AddDelayedTask( | 180 delayed_task_manager_.AddDelayedTask( |
113 std::move(task_a), | 181 std::move(task_a), BindOnce(&MockTaskTarget::PostTaskNowCallback, |
114 Bind(&MockTaskTarget::PostTaskNowCallback, Unretained(&task_target))); | 182 Unretained(&task_target_))); |
115 delayed_task_manager_.AddDelayedTask( | 183 delayed_task_manager_.AddDelayedTask( |
116 std::move(task_b), | 184 std::move(task_b), BindOnce(&MockTaskTarget::PostTaskNowCallback, |
117 Bind(&MockTaskTarget::PostTaskNowCallback, Unretained(&task_target))); | 185 Unretained(&task_target_))); |
118 delayed_task_manager_.AddDelayedTask( | 186 delayed_task_manager_.AddDelayedTask( |
119 std::move(task_c), | 187 std::move(task_c), BindOnce(&MockTaskTarget::PostTaskNowCallback, |
120 Bind(&MockTaskTarget::PostTaskNowCallback, Unretained(&task_target))); | 188 Unretained(&task_target_))); |
121 | 189 |
122 // Run tasks that are ripe for execution on the service thread. Don't expect | 190 // Run tasks that are ripe for execution on the service thread. Don't expect |
123 // any call to |task_target|. | 191 // any call to |task_target_|. |
124 service_thread_task_runner_->RunUntilIdle(); | 192 service_thread_task_runner_->RunUntilIdle(); |
125 | 193 |
126 // Fast-forward time. Expect |task_a_raw| and |task_c_raw| to be forwarded to | 194 // Fast-forward time. Expect |task_a_raw| and |task_c_raw| to be forwarded to |
127 // |task_target|. | 195 // |task_target_|. |
128 EXPECT_CALL(task_target, DoPostTaskNowCallback(task_a_raw)); | 196 EXPECT_CALL(task_target_, DoPostTaskNowCallback(task_a_raw)); |
129 EXPECT_CALL(task_target, DoPostTaskNowCallback(task_c_raw)); | 197 EXPECT_CALL(task_target_, DoPostTaskNowCallback(task_c_raw)); |
130 service_thread_task_runner_->FastForwardBy(TimeDelta::FromHours(1)); | 198 service_thread_task_runner_->FastForwardBy(TimeDelta::FromHours(1)); |
131 testing::Mock::VerifyAndClear(&task_target); | 199 testing::Mock::VerifyAndClear(&task_target_); |
132 | 200 |
133 // Fast-forward time. Expect |task_b_raw| to be forwarded to |task_target|. | 201 // Fast-forward time. Expect |task_b_raw| to be forwarded to |task_target_|. |
134 EXPECT_CALL(task_target, DoPostTaskNowCallback(task_b_raw)); | 202 EXPECT_CALL(task_target_, DoPostTaskNowCallback(task_b_raw)); |
135 service_thread_task_runner_->FastForwardBy(TimeDelta::FromHours(1)); | 203 service_thread_task_runner_->FastForwardBy(TimeDelta::FromHours(1)); |
136 testing::Mock::VerifyAndClear(&task_target); | 204 testing::Mock::VerifyAndClear(&task_target_); |
137 } | 205 } |
138 | 206 |
139 } // namespace internal | 207 } // namespace internal |
140 } // namespace base | 208 } // namespace base |
OLD | NEW |