OLD | NEW |
---|---|
1 // Copyright 2016 The Chromium Authors. All rights reserved. | 1 // Copyright 2016 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "base/task_scheduler/delayed_task_manager.h" | 5 #include "base/task_scheduler/delayed_task_manager.h" |
6 | 6 |
7 #include <utility> | 7 #include <algorithm> |
8 | 8 |
9 #include "base/bind.h" | 9 #include "base/bind.h" |
10 #include "base/logging.h" | 10 #include "base/logging.h" |
11 #include "base/task_runner.h" | 11 #include "base/task_runner.h" |
12 #include "base/task_scheduler/task.h" | 12 #include "base/task_scheduler/task.h" |
13 | 13 |
14 namespace base { | 14 namespace base { |
15 namespace internal { | 15 namespace internal { |
16 | 16 |
17 DelayedTaskManager::DelayedTaskManager( | 17 DelayedTaskManager::DelayedTaskManager(std::unique_ptr<TickClock> tick_clock) |
18 scoped_refptr<TaskRunner> service_thread_task_runner) | 18 : tick_clock_(std::move(tick_clock)) { |
19 : service_thread_task_runner_(std::move(service_thread_task_runner)) { | 19 DCHECK(tick_clock_); |
20 DCHECK(service_thread_task_runner_); | |
21 } | 20 } |
22 | 21 |
23 DelayedTaskManager::~DelayedTaskManager() = default; | 22 DelayedTaskManager::~DelayedTaskManager() = default; |
24 | 23 |
24 void DelayedTaskManager::Start( | |
25 scoped_refptr<TaskRunner> service_thread_task_runner) { | |
26 decltype(tasks_added_before_start_) tasks_added_before_start; | |
27 | |
28 { | |
29 AutoSchedulerLock auto_lock(lock_); | |
30 DCHECK(service_thread_task_runner); | |
robliao
2017/04/19 17:54:07
Nit: Move this DCHECK to the top of the function n
fdoray
2017/04/20 12:08:52
Done.
| |
31 DCHECK(!service_thread_task_runner_); | |
32 DCHECK(!started_.IsSet()); | |
33 service_thread_task_runner_ = std::move(service_thread_task_runner); | |
34 tasks_added_before_start = std::move(tasks_added_before_start_); | |
35 // |service_thread_task_runner_| must not change after |started_| is set. | |
robliao
2017/04/19 17:54:07
Add a note explaining the why (accesses to service
fdoray
2017/04/20 12:08:52
Done.
| |
36 started_.Set(); | |
37 } | |
38 | |
39 const TimeTicks now = tick_clock_->NowTicks(); | |
40 for (auto& task_and_callback : tasks_added_before_start) { | |
41 const TimeDelta delay = | |
42 std::max(TimeDelta(), task_and_callback.first->delayed_run_time - now); | |
43 AddDelayedTaskNow(std::move(task_and_callback.first), delay, | |
44 std::move(task_and_callback.second)); | |
45 } | |
46 } | |
47 | |
25 void DelayedTaskManager::AddDelayedTask( | 48 void DelayedTaskManager::AddDelayedTask( |
26 std::unique_ptr<Task> task, | 49 std::unique_ptr<Task> task, |
27 const PostTaskNowCallback& post_task_now_callback) { | 50 PostTaskNowCallback post_task_now_callback) { |
28 DCHECK(task); | 51 DCHECK(task); |
29 | 52 |
53 const TimeDelta delay = task->delay; | |
54 DCHECK(!delay.is_zero()); | |
55 | |
30 // Use CHECK instead of DCHECK to crash earlier. See http://crbug.com/711167 | 56 // Use CHECK instead of DCHECK to crash earlier. See http://crbug.com/711167 |
31 // for details. | 57 // for details. |
32 CHECK(task->task); | 58 CHECK(task->task); |
33 | 59 |
34 const TimeDelta delay = task->delay; | 60 if (started_.IsSet()) { |
35 DCHECK(!delay.is_zero()); | 61 // Fast path. |
robliao
2017/04/19 17:54:07
Remove this comment and the one below. It's not cl
fdoray
2017/04/20 12:08:52
Done.
| |
62 AddDelayedTaskNow(std::move(task), delay, | |
63 std::move(post_task_now_callback)); | |
64 } else { | |
65 // Slow path. | |
66 AutoSchedulerLock auto_lock(lock_); | |
67 if (started_.IsSet()) { | |
68 AddDelayedTaskNow(std::move(task), delay, | |
69 std::move(post_task_now_callback)); | |
70 } else { | |
71 tasks_added_before_start_.push_back( | |
72 {std::move(task), std::move(post_task_now_callback)}); | |
73 } | |
74 } | |
75 } | |
36 | 76 |
77 void DelayedTaskManager::AddDelayedTaskNow( | |
78 std::unique_ptr<Task> task, | |
79 TimeDelta delay, | |
80 PostTaskNowCallback post_task_now_callback) { | |
81 DCHECK(task); | |
82 DCHECK(started_.IsSet()); | |
37 // TODO(fdoray): Use |task->delayed_run_time| on the service thread | 83 // TODO(fdoray): Use |task->delayed_run_time| on the service thread |
38 // MessageLoop rather than recomputing it from |delay|. | 84 // MessageLoop rather than recomputing it from |delay|. |
39 service_thread_task_runner_->PostDelayedTask( | 85 service_thread_task_runner_->PostDelayedTask( |
40 FROM_HERE, BindOnce(post_task_now_callback, Passed(std::move(task))), | 86 FROM_HERE, |
87 BindOnce(std::move(post_task_now_callback), Passed(std::move(task))), | |
41 delay); | 88 delay); |
42 } | 89 } |
43 | 90 |
44 } // namespace internal | 91 } // namespace internal |
45 } // namespace base | 92 } // namespace base |
OLD | NEW |