Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

Issue 2810873007: Replace LayoutPart::GetFrameViewBase with GetNodeFrameView (Closed)
Patch Set: No need for child_frame_view var Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp b/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
index 74162c927f34a4271044ac05f414d220404281a9..c2a111355807fce8caaba42926ca93863b15da36 100644
--- a/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
+++ b/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
@@ -670,10 +670,10 @@ TEST_P(ScrollingCoordinatorTest, iframeScrolling) {
LayoutPart* layout_part = ToLayoutPart(layout_object);
ASSERT_TRUE(layout_part);
- ASSERT_TRUE(layout_part->GetFrameViewBase());
- ASSERT_TRUE(layout_part->GetFrameViewBase()->IsFrameView());
- FrameView* inner_frame_view = ToFrameView(layout_part->GetFrameViewBase());
+ FrameView* inner_frame_view = layout_part->ChildFrameView();
+ ASSERT_TRUE(inner_frame_view);
+
LayoutViewItem inner_layout_view_item = inner_frame_view->GetLayoutViewItem();
ASSERT_FALSE(inner_layout_view_item.IsNull());
@@ -722,10 +722,10 @@ TEST_P(ScrollingCoordinatorTest, rtlIframe) {
LayoutPart* layout_part = ToLayoutPart(layout_object);
ASSERT_TRUE(layout_part);
- ASSERT_TRUE(layout_part->GetFrameViewBase());
- ASSERT_TRUE(layout_part->GetFrameViewBase()->IsFrameView());
- FrameView* inner_frame_view = ToFrameView(layout_part->GetFrameViewBase());
+ FrameView* inner_frame_view = layout_part->ChildFrameView();
+ ASSERT_TRUE(inner_frame_view);
+
LayoutViewItem inner_layout_view_item = inner_frame_view->GetLayoutViewItem();
ASSERT_FALSE(inner_layout_view_item.IsNull());
@@ -900,10 +900,10 @@ TEST_P(ScrollingCoordinatorTest,
LayoutPart* layout_part = ToLayoutPart(layout_object);
ASSERT_TRUE(layout_part);
- ASSERT_TRUE(layout_part->GetFrameViewBase());
- ASSERT_TRUE(layout_part->GetFrameViewBase()->IsFrameView());
- FrameView* inner_frame_view = ToFrameView(layout_part->GetFrameViewBase());
+ FrameView* inner_frame_view = layout_part->ChildFrameView();
+ ASSERT_TRUE(inner_frame_view);
+
LayoutViewItem inner_layout_view_item = inner_frame_view->GetLayoutViewItem();
ASSERT_FALSE(inner_layout_view_item.IsNull());
« no previous file with comments | « third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698