third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp - Issue 2810873007: Replace LayoutPart::GetFrameViewBase with GetNodeFrameView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

Issue 2810873007: Replace LayoutPart::GetFrameViewBase with GetNodeFrameView (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp b/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

index 66b0374e619429a62e7d7b77a3a51b3a5ffa2e59..369f1cfdb267cdc56963b4eaa73e5c9468748826 100644

--- a/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

+++ b/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

@@ -670,10 +670,10 @@ TEST_P(ScrollingCoordinatorTest, iframeScrolling) {

LayoutPart* layout_part = ToLayoutPart(layout_object);

ASSERT_TRUE(layout_part);

- ASSERT_TRUE(layout_part->GetFrameViewBase());

- ASSERT_TRUE(layout_part->GetFrameViewBase()->IsFrameView());

- FrameView* inner_frame_view = ToFrameView(layout_part->GetFrameViewBase());

+ FrameView* inner_frame_view = layout_part->GetNodeFrameView();

+ ASSERT_TRUE(inner_frame_view);

LayoutViewItem inner_layout_view_item = inner_frame_view->GetLayoutViewItem();

ASSERT_FALSE(inner_layout_view_item.IsNull());

@@ -722,10 +722,10 @@ TEST_P(ScrollingCoordinatorTest, rtlIframe) {

LayoutPart* layout_part = ToLayoutPart(layout_object);

ASSERT_TRUE(layout_part);

- ASSERT_TRUE(layout_part->GetFrameViewBase());

- ASSERT_TRUE(layout_part->GetFrameViewBase()->IsFrameView());

- FrameView* inner_frame_view = ToFrameView(layout_part->GetFrameViewBase());

+ FrameView* inner_frame_view = layout_part->GetNodeFrameView();

+ ASSERT_TRUE(inner_frame_view);

LayoutViewItem inner_layout_view_item = inner_frame_view->GetLayoutViewItem();

ASSERT_FALSE(inner_layout_view_item.IsNull());

@@ -900,10 +900,10 @@ TEST_P(ScrollingCoordinatorTest,

LayoutPart* layout_part = ToLayoutPart(layout_object);

ASSERT_TRUE(layout_part);

- ASSERT_TRUE(layout_part->GetFrameViewBase());

- ASSERT_TRUE(layout_part->GetFrameViewBase()->IsFrameView());

- FrameView* inner_frame_view = ToFrameView(layout_part->GetFrameViewBase());

+ FrameView* inner_frame_view = layout_part->GetNodeFrameView();

+ ASSERT_TRUE(inner_frame_view);

LayoutViewItem inner_layout_view_item = inner_frame_view->GetLayoutViewItem();

ASSERT_FALSE(inner_layout_view_item.IsNull());