Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1375)

Unified Diff: third_party/WebKit/Source/core/frame/DOMTimerTest.cpp

Issue 2810843002: bindings: Make the sequence conversion code more complaint with WebIDL. (Closed)
Patch Set: Adjust even more tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/DOMTimerTest.cpp
diff --git a/third_party/WebKit/Source/core/frame/DOMTimerTest.cpp b/third_party/WebKit/Source/core/frame/DOMTimerTest.cpp
index eb9691694e69753733cc2f15191ad7da57b9b694..dca9dd47b7c66ccbcc0709d920aff68d30882ce8 100644
--- a/third_party/WebKit/Source/core/frame/DOMTimerTest.cpp
+++ b/third_party/WebKit/Source/core/frame/DOMTimerTest.cpp
@@ -6,6 +6,8 @@
#include <vector>
+#include "bindings/core/v8/IDLTypes.h"
+#include "bindings/core/v8/NativeValueTraitsImpl.h"
#include "bindings/core/v8/ScriptController.h"
#include "bindings/core/v8/ScriptSourceCode.h"
#include "bindings/core/v8/V8Binding.h"
@@ -60,8 +62,8 @@ class DOMTimerTest : public RenderingTest {
Vector<double> ToDoubleArray(v8::Local<v8::Value> value,
v8::HandleScope& scope) {
NonThrowableExceptionState exception_state;
- return ToImplArray<Vector<double>>(value, 0, scope.GetIsolate(),
- exception_state);
+ return NativeValueTraits<IDLSequence<IDLDouble>>::NativeValue(
+ scope.GetIsolate(), value, exception_state);
}
double ToDoubleValue(v8::Local<v8::Value> value, v8::HandleScope& scope) {
« no previous file with comments | « third_party/WebKit/Source/core/core_idl_files.gni ('k') | third_party/WebKit/Source/core/testing/Internals.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698