third_party/WebKit/Source/bindings/templates/union_container.cpp.tmpl - Issue 2810843002: bindings: Make the sequence conversion code more complaint with WebIDL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/union_container.cpp.tmpl

Issue 2810843002: bindings: Make the sequence conversion code more complaint with WebIDL. (Closed)

Patch Set: Adjust even more tests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/v8_types.py ('k') | third_party/WebKit/Source/bindings/tests/results/core/BooleanOrElementSequence.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/union_container.cpp.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/union_container.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/union_container.cpp.tmpl

index e361c1b8ac69763b698f5aea204362401a705175..5374e7c8cd437fd89dba438caec91d0a9bcd21de 100644

--- a/third_party/WebKit/Source/bindings/templates/union_container.cpp.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/union_container.cpp.tmpl

@@ -109,10 +109,7 @@ void {{v8_class}}::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, {{

{% endif %}

{% if array_or_sequence_type %}

{# 11.1, 11.2. Arrays and Sequences #}

- {# FIXME: This should also check "object but not RegExp". Add checks

- when we implement conversions for Date and RegExp. #}

- {# TODO(bashi): Should check @@iterator symbol instead. #}

- if (v8Value->IsArray()) {

+ if (IsV8Sequence(isolate, v8Value, exceptionState)) {

impl.set{{array_or_sequence_type.type_name}}(cppValue);

return;