Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.cpp

Issue 2810843002: bindings: Make the sequence conversion code more complaint with WebIDL. (Closed)
Patch Set: Adjust even more tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.cpp b/third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.cpp
index a075ee1c2a83dc15b8ac9c8d1b55dc89b0766fa3..b0f44d2702e5573dc4f8190733959f0fc9a98c1c 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.cpp
@@ -122,16 +122,6 @@ String ExceptionMessages::ArgumentNullOrIncorrectType(
" object.";
}
-String ExceptionMessages::NotAnArrayTypeArgumentOrValue(int argument_index) {
- String kind;
- if (argument_index) // method argument
- kind = OrdinalNumber(argument_index) + " argument";
- else // value, e.g. attribute setter
- kind = "value provided";
- return "The " + kind +
- " is neither an array, nor does it have indexed properties.";
-}
-
String ExceptionMessages::NotASequenceTypeProperty(
const String& property_name) {
return "'" + property_name +

Powered by Google App Engine
This is Rietveld 408576698