third_party/WebKit/LayoutTests/fast/events/constructors/message-event-constructor.html - Issue 2810843002: bindings: Make the sequence conversion code more complaint with WebIDL.

Unified Diff: third_party/WebKit/LayoutTests/fast/events/constructors/message-event-constructor.html

Issue 2810843002: bindings: Make the sequence conversion code more complaint with WebIDL. (Closed)

Patch Set: Adjust even more tests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/idl-union-type-unittest-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/events/constructors/message-event-constructor-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/events/constructors/message-event-constructor.html

diff --git a/third_party/WebKit/LayoutTests/fast/events/constructors/message-event-constructor.html b/third_party/WebKit/LayoutTests/fast/events/constructors/message-event-constructor.html

index 55f18f8bb8ae0a1651bd67aa152fa3f461106cce..9061746d157b8b1d73beab876eed7d9b08b831a7 100644

--- a/third_party/WebKit/LayoutTests/fast/events/constructors/message-event-constructor.html

+++ b/third_party/WebKit/LayoutTests/fast/events/constructors/message-event-constructor.html

@@ -119,6 +119,7 @@ shouldThrow("new MessageEvent('eventType', { get ports() { return 123; } }).port

shouldThrow("new MessageEvent('eventType', { get ports() { throw 'MessageEvent Error'; } })");

// Note that valueOf() is not called, when the left hand side is evaluated.

shouldThrow("new MessageEvent('eventType', { ports: {valueOf: function () { return [channel.port1, channel.port2, channel.port2]; } } }).ports[0]");

+shouldThrow("new MessageEvent('eventType', { bubbles: true, cancelable: true, data: test_object, origin: 'wonderful', lastEventId: 'excellent', source: window, ports: {length: 3, 0: channel.port1, 1: channel.port2, 2: channel2.port1} }).ports[2]");

// All initializers are passed.

shouldBe("new MessageEvent('eventType', { bubbles: true, cancelable: true, data: test_object, origin: 'wonderful', lastEventId: 'excellent', source: window, ports: [channel.port1, channel.port2, channel2.port1] }).bubbles", "true");

@@ -130,7 +131,6 @@ shouldBe("new MessageEvent('eventType', { bubbles: true, cancelable: true, data:

-shouldBe("new MessageEvent('eventType', { bubbles: true, cancelable: true, data: test_object, origin: 'wonderful', lastEventId: 'excellent', source: window, ports: {length: 3, 0: channel.port1, 1: channel.port2, 2: channel2.port1} }).ports[2]", "channel2.port1");

</script>

</body>

</html>