Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp

Issue 2810843002: bindings: Make the sequence conversion code more complaint with WebIDL. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp
diff --git a/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp b/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp
index d11f3606e44e4526a0b9529d2264f4391c53ec43..1daf8655ac34ef1ff2a67d7f8dcbbde7f320eea7 100644
--- a/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp
+++ b/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp
@@ -4,6 +4,8 @@
#include "modules/csspaint/PaintWorkletGlobalScope.h"
+#include "bindings/core/v8/IDLTypes.h"
+#include "bindings/core/v8/NativeValueTraitsImpl.h"
#include "bindings/core/v8/V8BindingMacros.h"
#include "bindings/core/v8/WorkerOrWorkletScriptController.h"
#include "core/CSSPropertyNames.h"
@@ -88,8 +90,9 @@ void PaintWorkletGlobalScope::registerPaint(const String& name,
Vector<AtomicString> custom_invalidation_properties;
if (!IsUndefinedOrNull(input_properties_value)) {
- Vector<String> properties = ToImplArray<Vector<String>>(
- input_properties_value, 0, isolate, exception_state);
+ Vector<String> properties =
+ NativeValueTraits<IDLSequence<IDLString>>::NativeValue(
+ isolate, input_properties_value, exception_state);
if (exception_state.HadException())
return;
@@ -114,8 +117,9 @@ void PaintWorkletGlobalScope::registerPaint(const String& name,
return;
if (!IsUndefinedOrNull(input_argument_type_values)) {
- Vector<String> argument_types = ToImplArray<Vector<String>>(
- input_argument_type_values, 0, isolate, exception_state);
+ Vector<String> argument_types =
+ NativeValueTraits<IDLSequence<IDLString>>::NativeValue(
+ isolate, input_argument_type_values, exception_state);
if (exception_state.HadException())
return;

Powered by Google App Engine
This is Rietveld 408576698