Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/StringOrStringSequence.cpp

Issue 2810843002: bindings: Make the sequence conversion code more complaint with WebIDL. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/StringOrStringSequence.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/StringOrStringSequence.cpp b/third_party/WebKit/Source/bindings/tests/results/core/StringOrStringSequence.cpp
index 521152dc008fab02bfdf6c68f39451f4ea82fbbd..87dde2641cdfec2e368531470a1614790dffc522 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/StringOrStringSequence.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/StringOrStringSequence.cpp
@@ -67,8 +67,8 @@ void V8StringOrStringSequence::toImpl(v8::Isolate* isolate, v8::Local<v8::Value>
if (conversionMode == UnionTypeConversionMode::kNullable && IsUndefinedOrNull(v8Value))
return;
- if (v8Value->IsArray()) {
- Vector<String> cppValue = ToImplArray<Vector<String>>(v8Value, 0, isolate, exceptionState);
+ if (IsV8Sequence(v8Value, isolate, exceptionState)) {
+ Vector<String> cppValue = NativeValueTraits<IDLSequence<IDLString>>::NativeValue(isolate, v8Value, exceptionState);
if (exceptionState.HadException())
return;
impl.setStringSequence(cppValue);

Powered by Google App Engine
This is Rietveld 408576698