third_party/WebKit/Source/bindings/tests/results/core/StringOrStringSequence.cpp - Issue 2810843002: bindings: Make the sequence conversion code more complaint with WebIDL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/StringOrStringSequence.cpp

Issue 2810843002: bindings: Make the sequence conversion code more complaint with WebIDL. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8Binding.h ('K') | « third_party/WebKit/Source/bindings/tests/results/core/NodeOrLongSequenceOrEventOrXMLHttpRequestOrStringOrStringByteStringOrNodeListRecord.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.cpp » ('j') | third_party/WebKit/Source/modules/webdatabase/SQLTransaction.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/StringOrStringSequence.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/StringOrStringSequence.cpp b/third_party/WebKit/Source/bindings/tests/results/core/StringOrStringSequence.cpp

index 521152dc008fab02bfdf6c68f39451f4ea82fbbd..87dde2641cdfec2e368531470a1614790dffc522 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/StringOrStringSequence.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/StringOrStringSequence.cpp

@@ -67,8 +67,8 @@ void V8StringOrStringSequence::toImpl(v8::Isolate* isolate, v8::Local<v8::Value>

if (conversionMode == UnionTypeConversionMode::kNullable && IsUndefinedOrNull(v8Value))

return;

- if (v8Value->IsArray()) {

- Vector<String> cppValue = ToImplArray<Vector<String>>(v8Value, 0, isolate, exceptionState);

+ if (IsV8Sequence(v8Value, isolate, exceptionState)) {

+ Vector<String> cppValue = NativeValueTraits<IDLSequence<IDLString>>::NativeValue(isolate, v8Value, exceptionState);

if (exceptionState.HadException())

return;

impl.setStringSequence(cppValue);