Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp

Issue 2810843002: bindings: Make the sequence conversion code more complaint with WebIDL. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp
index 6ea313aa2850804623f2255e14b5d7bbb6697f42..0b6c26b26d1eb15e63919ead698cf073c26b56d0 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp
@@ -30,6 +30,8 @@
#include "bindings/core/v8/ScriptPromise.h"
+#include "bindings/core/v8/IDLTypes.h"
+#include "bindings/core/v8/NativeValueTraitsImpl.h"
#include "bindings/core/v8/ScriptFunction.h"
#include "bindings/core/v8/ScriptValue.h"
#include "bindings/core/v8/V8Binding.h"
@@ -90,8 +92,8 @@ String ToString(v8::Local<v8::Context> context, const ScriptValue& value) {
Vector<String> ToStringArray(v8::Isolate* isolate, const ScriptValue& value) {
NonThrowableExceptionState exception_state;
- return ToImplArray<Vector<String>>(value.V8Value(), 0, isolate,
- exception_state);
+ return NativeValueTraits<IDLSequence<IDLString>>::NativeValue(
+ isolate, value.V8Value(), exception_state);
}
TEST(ScriptPromiseTest, constructFromNonPromise) {

Powered by Google App Engine
This is Rietveld 408576698