third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.h - Issue 2810843002: bindings: Make the sequence conversion code more complaint with WebIDL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.h

Issue 2810843002: bindings: Make the sequence conversion code more complaint with WebIDL. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.h b/third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.h

index 60f020b14440331ea9988eb2d97f8859c3409b41..46366cf5cb814cd1ee1c0f006a5b753a085a5878 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.h

@@ -140,9 +140,6 @@ class CORE_EXPORT ExceptionMessages {

static String InvalidArity(const char* expected, unsigned provided);

- // If > 0, the argument index that failed type check (1-indexed.)

- // If == 0, a (non-argument) value (e.g., a setter) failed the same check.

- static String NotAnArrayTypeArgumentOrValue(int argument_index);

static String NotASequenceTypeProperty(const String& property_name);

static String NotAFiniteNumber(double value,

const char* name = "value provided");