bindings: Make the sequence conversion code more complaint with WebIDL.

third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 16 matching lines @@
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "bindings/core/v8/SerializedScriptValue.h"
 
 #include <memory>
 #include "bindings/core/v8/DOMDataStore.h"
 #include "bindings/core/v8/DOMWrapperWorld.h"
 #include "bindings/core/v8/ExceptionState.h"
+#include "bindings/core/v8/IDLTypes.h"
+#include "bindings/core/v8/NativeValueTraitsImpl.h"
 #include "bindings/core/v8/ScriptState.h"
 #include "bindings/core/v8/SerializedScriptValueFactory.h"
 #include "bindings/core/v8/Transferables.h"
 #include "bindings/core/v8/V8ArrayBuffer.h"
 #include "bindings/core/v8/V8ImageBitmap.h"
 #include "bindings/core/v8/V8MessagePort.h"
 #include "bindings/core/v8/V8OffscreenCanvas.h"
 #include "bindings/core/v8/V8SharedArrayBuffer.h"
 #include "core/dom/DOMArrayBuffer.h"
 #include "core/dom/DOMSharedArrayBuffer.h"
@@ skipping 219 matching lines @@
 
 bool SerializedScriptValue::ExtractTransferables(
     v8::Isolate* isolate,
     v8::Local<v8::Value> value,
     int argument_index,
     Transferables& transferables,
     ExceptionState& exception_state) {
   if (value.IsEmpty() || value->IsUndefined())
     return true;
 
-  uint32_t length = 0;
-  if (value->IsArray()) {
-    v8::Local<v8::Array> array = v8::Local<v8::Array>::Cast(value);
-    length = array->Length();
-  } else if (!ToV8Sequence(value, length, isolate, exception_state)) {
-    if (!exception_state.HadException())
-      exception_state.ThrowTypeError(
-          ExceptionMessages::NotAnArrayTypeArgumentOrValue(argument_index + 1));
-    return false;
-  }
-
-  v8::Local<v8::Object> transferable_array = v8::Local<v8::Object>::Cast(value);
+  Vector<v8::Local<v8::Value>> transferable_array =
+      NativeValueTraits<IDLSequence<v8::Local<v8::Value>>>::NativeValue(
+          isolate, value, exception_state);
 
   // Validate the passed array of transferables.
-  for (unsigned i = 0; i < length; ++i) {
-    v8::Local<v8::Value> transferable_object;
-    if (!transferable_array->Get(isolate->GetCurrentContext(), i)
-             .ToLocal(&transferable_object))
-      return false;
+  uint32_t i = 0;
+  for (const auto& transferable_object : transferable_array) {
     // Validation of non-null objects, per HTML5 spec 10.3.3.
     if (IsUndefinedOrNull(transferable_object)) {
       exception_state.ThrowTypeError(
           "Value at index " + String::Number(i) + " is an untransferable " +
           (transferable_object->IsUndefined() ? "'undefined'" : "'null'") +
           " value.");
       return false;
     }
     // Validation of Objects implementing an interface, per WebIDL spec 4.1.15.
     if (V8MessagePort::hasInstance(transferable_object, isolate)) {
@@ skipping 47 matching lines @@
             "OffscreenCanvas at index " + String::Number(i) +
                 " is a duplicate of an earlier OffscreenCanvas.");
         return false;
       }
       transferables.offscreen_canvases.push_back(offscreen_canvas);
     } else {
       exception_state.ThrowTypeError("Value at index " + String::Number(i) +
                                      " does not have a transferable type.");
       return false;
     }
+    i++;
   }
   return true;
 }
 
 std::unique_ptr<SerializedScriptValue::ArrayBufferContentsArray>
 SerializedScriptValue::TransferArrayBufferContents(
     v8::Isolate* isolate,
     const ArrayBufferArray& array_buffers,
     ExceptionState& exception_state) {
   if (!array_buffers.size())
@@ skipping 90 matching lines @@
   // Only (re)register allocation cost for transferables if this
   // SerializedScriptValue has explicitly unregistered them before.
   if (array_buffer_contents_array_ &&
       transferables_need_external_allocation_registration_) {
     for (auto& buffer : *array_buffer_contents_array_)
       buffer.RegisterExternalAllocationWithCurrentContext();
   }
 }
 
 }  // namespace blink