bindings: Make the sequence conversion code more complaint with WebIDL.

third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/cachestorage/Cache.h"
 
+#include <algorithm>
+#include <memory>
+#include <string>
 #include "bindings/core/v8/ExceptionState.h"
+#include "bindings/core/v8/IDLTypes.h"
+#include "bindings/core/v8/NativeValueTraitsImpl.h"
 #include "bindings/core/v8/ScriptFunction.h"
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "bindings/core/v8/ScriptValue.h"
 #include "bindings/core/v8/V8Binding.h"
 #include "bindings/modules/v8/V8Request.h"
 #include "bindings/modules/v8/V8Response.h"
 #include "core/dom/Document.h"
 #include "core/frame/Frame.h"
 #include "core/testing/DummyPageHolder.h"
 #include "modules/fetch/BodyStreamBuffer.h"
 #include "modules/fetch/FormDataBytesConsumer.h"
 #include "modules/fetch/GlobalFetch.h"
 #include "modules/fetch/Request.h"
 #include "modules/fetch/Response.h"
 #include "modules/fetch/ResponseInit.h"
 #include "public/platform/WebURLResponse.h"
 #include "public/platform/modules/serviceworker/WebServiceWorkerCache.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "wtf/PtrUtil.h"
-#include <algorithm>
-#include <memory>
-#include <string>
 
 namespace blink {
 
 namespace {
 
 const char kNotImplementedString[] =
     "NotSupportedError: Method is not implemented.";
 
 class ScopedFetcherForTests final
     : public GarbageCollectedFinalized<ScopedFetcherForTests>,
@@ skipping 562 matching lines @@
 
   WebVector<WebServiceWorkerRequest> web_requests(size_t(2));
   web_requests[0].SetURL(KURL(kParsedURLString, url1));
   web_requests[1].SetURL(KURL(kParsedURLString, url2));
 
   Cache* cache = CreateCache(fetcher, new KeysTestCache(web_requests));
 
   ScriptPromise result = cache->keys(GetScriptState(), exception_state);
   ScriptValue script_value = GetResolveValue(result);
 
-  Vector<v8::Local<v8::Value>> requests =
-      ToImplArray<Vector<v8::Local<v8::Value>>>(script_value.V8Value(), 0,
-                                                GetIsolate(), exception_state);
+  HeapVector<Member<Request>> requests =
+      NativeValueTraits<IDLSequence<Request>>::NativeValue(
+          GetIsolate(), script_value.V8Value(), exception_state);
   EXPECT_EQ(expected_urls.size(), requests.size());
   for (int i = 0, minsize = std::min(expected_urls.size(), requests.size());
        i < minsize; ++i) {
-    Request* request =
-        V8Request::toImplWithTypeCheck(GetIsolate(), requests[i]);
+    Request* request = requests[i];
     EXPECT_TRUE(request);
     if (request)
       EXPECT_EQ(expected_urls[i], request->url());
   }
 }
 
 class MatchAllAndBatchTestCache : public NotImplementedErrorCache {
  public:
   MatchAllAndBatchTestCache(WebVector<WebServiceWorkerResponse>& responses)
       : responses_(responses) {}
@@ skipping 35 matching lines @@
 
   Cache* cache =
       CreateCache(fetcher, new MatchAllAndBatchTestCache(web_responses));
 
   CacheQueryOptions options;
   ScriptPromise result =
       cache->matchAll(GetScriptState(), StringToRequestInfo("http://some.url/"),
                       options, exception_state);
   ScriptValue script_value = GetResolveValue(result);
 
-  Vector<v8::Local<v8::Value>> responses =
-      ToImplArray<Vector<v8::Local<v8::Value>>>(script_value.V8Value(), 0,
-                                                GetIsolate(), exception_state);
+  HeapVector<Member<Response>> responses =
+      NativeValueTraits<IDLSequence<Response>>::NativeValue(
+          GetIsolate(), script_value.V8Value(), exception_state);
   EXPECT_EQ(expected_urls.size(), responses.size());
   for (int i = 0, minsize = std::min(expected_urls.size(), responses.size());
        i < minsize; ++i) {
-    Response* response =
-        V8Response::toImplWithTypeCheck(GetIsolate(), responses[i]);
+    Response* response = responses[i];
     EXPECT_TRUE(response);
     if (response)
       EXPECT_EQ(expected_urls[i], response->url());
   }
 
   result = cache->deleteFunction(GetScriptState(),
                                  StringToRequestInfo("http://some.url/"),
                                  options, exception_state);
   script_value = GetResolveValue(result);
   EXPECT_TRUE(script_value.V8Value()->IsBoolean());
@@ skipping 38 matching lines @@
 
   EXPECT_EQ(kNotImplementedString, GetRejectString(add_result));
   EXPECT_EQ(1, fetcher->FetchCount());
   EXPECT_EQ("dispatchBatch",
             test_cache->GetAndClearLastErrorWebCacheMethodCalled());
 }
 
 }  // namespace
 
 }  // namespace blink