Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: chrome/browser/about_flags.cc

Issue 2810833002: Add memory ablation experiment. (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/chrome_browser_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 85391be197f1dd09dc0a18158558e1ea25ada87c..cbccc4bf3871f9b6404545ae33b244de31a8cf0a 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -26,6 +26,7 @@
#include "base/values.h"
#include "build/build_config.h"
#include "cc/base/switches.h"
+#include "chrome/browser/experiments/memory_ablation_experiment.h"
#include "chrome/browser/flag_descriptions.h"
#include "chrome/browser/ntp_snippets/ntp_snippets_features.h"
#include "chrome/browser/predictors/resource_prefetch_common.h"
@@ -839,6 +840,21 @@ const FeatureEntry::FeatureVariation kUseNewDoodleApiVariations[] = {
arraysize(kUseNewDoodleApiTest8), nullptr}};
#endif // OS_ANDROID
+const FeatureEntry::FeatureParam kMemoryAblation1MiB[] = {
+ {kMemoryAblationFeatureSizeParam, "1048576"}};
+const FeatureEntry::FeatureParam kMemoryAblation5MiB[] = {
+ {kMemoryAblationFeatureSizeParam, "5242880"}};
+const FeatureEntry::FeatureParam kMemoryAblation10MiB[] = {
+ {kMemoryAblationFeatureSizeParam, "10485760"}};
+const FeatureEntry::FeatureParam kMemoryAblation50MiB[] = {
+ {kMemoryAblationFeatureSizeParam, "52428800"}};
+
+const FeatureEntry::FeatureVariation kMemoryAblationFeatureVariations[] = {
+ {"1 MiB", kMemoryAblation1MiB, arraysize(kMemoryAblation1MiB), nullptr},
+ {"5 MiB", kMemoryAblation5MiB, arraysize(kMemoryAblation5MiB), nullptr},
+ {"10 MiB", kMemoryAblation10MiB, arraysize(kMemoryAblation10MiB), nullptr},
+ {"50 MiB", kMemoryAblation50MiB, arraysize(kMemoryAblation50MiB), nullptr}};
+
#if defined(OS_ANDROID)
const FeatureEntry::FeatureParam kPersistentMenuItemEnabled[] = {
{"persistent_menu_item_enabled", "true"}};
@@ -2607,6 +2623,12 @@ const FeatureEntry kFeatureEntries[] = {
chrome::android::kUseNewDoodleApi.name)},
#endif // OS_ANDROID
+ {"memory-ablation", flag_descriptions::kMemoryAblationName,
+ flag_descriptions::kMemoryAblationDescription, kOsAll,
+ FEATURE_WITH_PARAMS_VALUE_TYPE(kMemoryAblationFeature,
+ kMemoryAblationFeatureVariations,
+ "MemoryAblation")},
+
#if defined(OS_ANDROID)
{"enable-custom-context-menu",
flag_descriptions::kEnableCustomContextMenuName,
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/chrome_browser_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698