Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4953)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 2810813004: Hide fullscreen rotation jank (Closed)
Patch Set: Remove clearThumbnailPlaceholder fn Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/compositor/tab_content_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
index 44be9d6c3ef729a7307daa1a8f127e7cb85e28d7..d212f4396d14519cf1737ddfd85962441995bb60 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
@@ -2509,6 +2509,11 @@ public class Tab
mFullscreenManager.setPersistentFullscreenMode(enableFullscreen);
}
+ // When going into fullscreen, we want to remove any cached thumbnail of the Tab.
+ if (enableFullscreen && mNativeTabAndroid != 0) {
+ nativeClearThumbnailPlaceholder(mNativeTabAndroid);
+ }
+
RewindableIterator<TabObserver> observers = getTabObservers();
while (observers.hasNext()) {
observers.next().onToggleFullscreenMode(this, enableFullscreen);
@@ -3133,6 +3138,7 @@ public class Tab
InterceptNavigationDelegate delegate);
private native void nativeAttachToTabContentManager(long nativeTabAndroid,
TabContentManager tabContentManager);
+ private native void nativeClearThumbnailPlaceholder(long nativeTabAndroid);
private native boolean nativeHasPrerenderedUrl(long nativeTabAndroid, String url);
private native void nativeSetWebappManifestScope(long nativeTabAndroid, String scope);
private native void nativeEnableEmbeddedMediaExperience(long nativeTabAndroid, boolean enabled);
« no previous file with comments | « no previous file | chrome/browser/android/compositor/tab_content_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698