Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2128)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.h

Issue 2810813004: Hide fullscreen rotation jank (Closed)
Patch Set: Re-add feature flag Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.h
diff --git a/content/browser/renderer_host/render_widget_host_view_android.h b/content/browser/renderer_host/render_widget_host_view_android.h
index c85662a8057446de65c9cebc13511625fa0fea0c..30003ed7419c6bf318af185125ea7e1bfb156c27 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.h
+++ b/content/browser/renderer_host/render_widget_host_view_android.h
@@ -23,6 +23,7 @@
#include "cc/scheduler/begin_frame_source.h"
#include "components/viz/service/frame_sinks/frame_evictor.h"
#include "content/browser/android/content_view_core_impl_observer.h"
+#include "content/browser/renderer_host/fullscreen_jank_detector.h"
#include "content/browser/renderer_host/input/mouse_wheel_phase_handler.h"
#include "content/browser/renderer_host/input/stylus_text_selector.h"
#include "content/browser/renderer_host/render_widget_host_view_base.h"
@@ -161,6 +162,7 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid
std::unique_ptr<SyntheticGestureTarget> CreateSyntheticGestureTarget()
override;
void OnDidNavigateMainFrameToNewPage() override;
+ void OnFullscreenStateChanged() override;
void SetNeedsBeginFrames(bool needs_begin_frames) override;
cc::FrameSinkId GetFrameSinkId() override;
cc::FrameSinkId FrameSinkIdAtPoint(cc::SurfaceHittestDelegate* delegate,
@@ -238,6 +240,7 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid
// Non-virtual methods
void SetContentViewCore(ContentViewCoreImpl* content_view_core);
SkColor GetCachedBackgroundColor() const;
+ void ClearThumbnailPlaceholder();
void SendKeyEvent(const NativeWebKeyboardEvent& event);
void SendMouseEvent(const ui::MotionEventAndroid&, int action_button);
void SendMouseWheelEvent(const blink::WebMouseWheelEvent& event);
@@ -319,6 +322,8 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid
void UpdateBackgroundColor(SkColor color);
+ void EvictFrameIfNecessary();
+
// DevTools ScreenCast support for Android WebView.
void SynchronousCopyContents(const gfx::Rect& src_subrect_in_pixel,
const gfx::Size& dst_size_in_pixel,
@@ -436,6 +441,9 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid
gfx::Point prev_mousedown_point_;
int left_click_count_ = 0;
+ // Identifies janky frames.
+ std::unique_ptr<FullscreenJankDetector> fullscreen_jank_detector_;
+
cc::mojom::CompositorFrameSinkClient* renderer_compositor_frame_sink_ =
nullptr;

Powered by Google App Engine
This is Rietveld 408576698