Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1308)

Unified Diff: content/browser/renderer_host/compositor_impl_android.cc

Issue 2810813004: Hide fullscreen rotation jank (Closed)
Patch Set: Re-add feature flag Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/compositor_impl_android.cc
diff --git a/content/browser/renderer_host/compositor_impl_android.cc b/content/browser/renderer_host/compositor_impl_android.cc
index 341cd87fb2349283373ad7fd94f3b0c2871a9b97..29abda01aa860df414c4d0a02782b1442e70bb82 100644
--- a/content/browser/renderer_host/compositor_impl_android.cc
+++ b/content/browser/renderer_host/compositor_impl_android.cc
@@ -59,6 +59,7 @@
#include "content/common/gpu_stream_constants.h"
#include "content/public/browser/android/compositor.h"
#include "content/public/browser/android/compositor_client.h"
+#include "content/public/common/content_features.h"
#include "content/public/common/content_switches.h"
#include "gpu/command_buffer/client/context_support.h"
#include "gpu/command_buffer/client/gles2_interface.h"
@@ -602,14 +603,18 @@ void CompositorImpl::SetHasTransparentBackground(bool transparent) {
if (host_) {
host_->set_has_transparent_background(transparent);
- // Give a delay in setting the background color to avoid the color for
- // the normal mode (white) affecting the UI transition.
- base::ThreadTaskRunnerHandle::Get().get()->PostDelayedTask(
- FROM_HERE,
- base::Bind(&CompositorImpl::SetBackgroundColor,
- weak_factory_.GetWeakPtr(),
- transparent ? SK_ColorBLACK : SK_ColorWHITE),
- base::TimeDelta::FromMilliseconds(500));
+ // TODO(steimel): Remove this feature flag and the hack inside this if block
+ // once we're confident that the fullscreen transition hiding is working
+ // properly.
+ if (!base::FeatureList::IsEnabled(
+ features::kHideFullscreenTransitionJank)) {
+ base::ThreadTaskRunnerHandle::Get().get()->PostDelayedTask(
+ FROM_HERE,
+ base::Bind(&CompositorImpl::SetBackgroundColor,
+ weak_factory_.GetWeakPtr(),
+ transparent ? SK_ColorBLACK : SK_ColorWHITE),
+ base::TimeDelta::FromMilliseconds(500));
+ }
}
}

Powered by Google App Engine
This is Rietveld 408576698