Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: chrome/browser/android/compositor/compositor_view.cc

Issue 2810813004: Hide fullscreen rotation jank (Closed)
Patch Set: Clear thumbnail cache instead of hiding static layer. Break out results of changing fullscreen stat… Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/compositor/compositor_view.cc
diff --git a/chrome/browser/android/compositor/compositor_view.cc b/chrome/browser/android/compositor/compositor_view.cc
index 4b525711cbc5f59c6f6a1e0f101bafb52872234a..c5d5a4f87da9907df083c2188a829c962e022abb 100644
--- a/chrome/browser/android/compositor/compositor_view.cc
+++ b/chrome/browser/android/compositor/compositor_view.cc
@@ -185,10 +185,11 @@ void CompositorView::SetLayoutBounds(JNIEnv* env,
}
void CompositorView::SetBackground(bool visible, SkColor color) {
- if (overlay_video_mode_)
- visible = false;
root_layer_->SetBackgroundColor(color);
Khushal 2017/06/23 03:09:51 Another thing, this root_layer_ doesn't need to be
root_layer_->SetIsDrawable(visible);
+ compositor_->SetBackgroundColor(color);
+ compositor_->SetHasTransparentBackground(SkColorGetA(color) ==
+ SK_AlphaTRANSPARENT);
}
void CompositorView::SetOverlayVideoMode(JNIEnv* env,
@@ -197,7 +198,6 @@ void CompositorView::SetOverlayVideoMode(JNIEnv* env,
if (overlay_video_mode_ == enabled)
return;
overlay_video_mode_ = enabled;
- compositor_->SetHasTransparentBackground(enabled);
SetNeedsComposite(env, object);
}

Powered by Google App Engine
This is Rietveld 408576698