Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: third_party/WebKit/Source/web/FullscreenController.cpp

Issue 2810813004: Hide fullscreen rotation jank (Closed)
Patch Set: Show a black frame during fullscreen transitions to hide jank Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/FullscreenController.cpp
diff --git a/third_party/WebKit/Source/web/FullscreenController.cpp b/third_party/WebKit/Source/web/FullscreenController.cpp
index c0d5ec4b5b97e793509a5662d21cebcae86047e6..d64c879c41118ade197d3a0e237b318f2f1a3af9 100644
--- a/third_party/WebKit/Source/web/FullscreenController.cpp
+++ b/third_party/WebKit/Source/web/FullscreenController.cpp
@@ -78,6 +78,7 @@ void FullscreenController::DidEnterFullscreen() {
web_view_base_->SetVisualViewportOffset(FloatPoint());
state_ = State::kFullscreen;
+ web_view_base_->LayerTreeView()->SetIsFullscreen(true);
// Notify all local frames that we have entered fullscreen.
for (Frame* frame = web_view_base_->GetPage()->MainFrame(); frame;
@@ -266,6 +267,7 @@ void FullscreenController::DidUpdateLayout() {
// fullscreenElementChanged([..], nullptr) was called while exiting.
state_ = State::kInitial;
+ web_view_base_->LayerTreeView()->SetIsFullscreen(false);
Khushal 2017/05/24 02:12:24 Why not do this in DidExitFullScreen?
steimel 2017/05/24 19:32:58 To me it seemed to make more sense that is_fullscr
Khushal 2017/05/25 03:33:40 The kNeedsScrollAndStateRestore is needed for chan
steimel 2017/06/06 03:07:53 Done.
}
void FullscreenController::UpdatePageScaleConstraints(bool remove_constraints) {

Powered by Google App Engine
This is Rietveld 408576698