Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2810813004: Hide fullscreen rotation jank (Closed)
Patch Set: Make OnFullscreenStateChanged a function at the RWVHB level. cr feedback Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 40429d51814846c69671b3bce27a1af955e1452b..5bf30334f71e0250c02a6e1f9da6cc496cf11083 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -2032,6 +2032,11 @@ void WebContentsImpl::EnterFullscreenMode(const GURL& origin) {
if (delegate_)
delegate_->EnterFullscreenModeForTab(this, origin);
+ RenderWidgetHostViewBase* rwhvb =
+ static_cast<RenderWidgetHostViewBase*>(GetRenderWidgetHostView());
+ if (rwhvb)
+ rwhvb->OnFullscreenStateChanged(IsFullscreenForCurrentTab());
+
for (auto& observer : observers_)
observer.DidToggleFullscreenModeForTab(IsFullscreenForCurrentTab(), false);
}
@@ -2051,6 +2056,11 @@ void WebContentsImpl::ExitFullscreenMode(bool will_cause_resize) {
video_view->ExitFullscreen();
#endif
+ RenderWidgetHostViewBase* rwhvb =
Khushal 2017/06/15 18:42:56 Don't we need to call this after delegate_->ExitFu
steimel 2017/06/15 21:46:39 Done.
+ static_cast<RenderWidgetHostViewBase*>(GetRenderWidgetHostView());
+ if (rwhvb)
+ rwhvb->OnFullscreenStateChanged(IsFullscreenForCurrentTab());
+
if (delegate_)
delegate_->ExitFullscreenModeForTab(this);

Powered by Google App Engine
This is Rietveld 408576698