Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: content/browser/renderer_host/compositor_impl_android.cc

Issue 2810813004: Hide fullscreen rotation jank (Closed)
Patch Set: Refactor jank logic. Make RWHVA a WebContentsObserver to observe fullscreen state Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/compositor_impl_android.cc
diff --git a/content/browser/renderer_host/compositor_impl_android.cc b/content/browser/renderer_host/compositor_impl_android.cc
index fff5edb377455b6abe81f8e9a36ca5d764c3e107..d46f195dcb7b771dc710f66ffb6d86befb512868 100644
--- a/content/browser/renderer_host/compositor_impl_android.cc
+++ b/content/browser/renderer_host/compositor_impl_android.cc
@@ -587,15 +587,7 @@ void CompositorImpl::SetHasTransparentBackground(bool transparent) {
has_transparent_background_ = transparent;
if (host_) {
host_->set_has_transparent_background(transparent);
-
- // Give a delay in setting the background color to avoid the color for
- // the normal mode (white) affecting the UI transition.
- base::ThreadTaskRunnerHandle::Get().get()->PostDelayedTask(
- FROM_HERE,
- base::Bind(&CompositorImpl::SetBackgroundColor,
- weak_factory_.GetWeakPtr(),
- transparent ? SK_ColorBLACK : SK_ColorWHITE),
- base::TimeDelta::FromMilliseconds(500));
+ SetBackgroundColor(transparent ? SK_ColorBLACK : SK_ColorWHITE);
Khushal 2017/06/07 05:36:01 Could you leave a TODO here to set the color based
steimel 2017/06/13 23:15:44 Done.
}
}

Powered by Google App Engine
This is Rietveld 408576698