Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2980)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/android/compositor/compositor_view.cc

Issue 2810813004: Hide fullscreen rotation jank (Closed)
Patch Set: make overlay_video_mode not affect background transparency Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/layer_tree_impl.cc ('k') | content/browser/renderer_host/render_widget_host_view_android.h » ('j') | content/browser/renderer_host/render_widget_host_view_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/compositor/compositor_view.cc
diff --git a/chrome/browser/android/compositor/compositor_view.cc b/chrome/browser/android/compositor/compositor_view.cc
index 4b525711cbc5f59c6f6a1e0f101bafb52872234a..1cfef2a6b8cc8f2ed09edac4c0ace7b7348c7c22 100644
--- a/chrome/browser/android/compositor/compositor_view.cc
+++ b/chrome/browser/android/compositor/compositor_view.cc
@@ -185,10 +185,9 @@ void CompositorView::SetLayoutBounds(JNIEnv* env,
}
void CompositorView::SetBackground(bool visible, SkColor color) {
- if (overlay_video_mode_)
- visible = false;
root_layer_->SetBackgroundColor(color);
root_layer_->SetIsDrawable(visible);
+ compositor_->SetHasTransparentBackground(SkColorGetA(color) == SK_AlphaTRANSPARENT);
Khushal 2017/05/31 20:26:51 Can you also remove the hack in CompositorImpl?
steimel 2017/06/06 03:07:54 Done.
}
void CompositorView::SetOverlayVideoMode(JNIEnv* env,
@@ -197,7 +196,6 @@ void CompositorView::SetOverlayVideoMode(JNIEnv* env,
if (overlay_video_mode_ == enabled)
return;
overlay_video_mode_ = enabled;
- compositor_->SetHasTransparentBackground(enabled);
SetNeedsComposite(env, object);
}
« no previous file with comments | « cc/trees/layer_tree_impl.cc ('k') | content/browser/renderer_host/render_widget_host_view_android.h » ('j') | content/browser/renderer_host/render_widget_host_view_android.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698