Hide fullscreen rotation jank

content/browser/web_contents/web_contents_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_impl.h"
 
 #include <stddef.h>
 
 #include <cmath>
 #include <utility>
@@ skipping 2018 matching lines @@
   // Make sure any existing fullscreen widget is shut down first.
   RenderWidgetHostView* const widget_view = GetFullscreenRenderWidgetHostView();
   if (widget_view) {
     RenderWidgetHostImpl::From(widget_view->GetRenderWidgetHost())
         ->ShutdownAndDestroyWidget(true);
   }
 
   if (delegate_)
     delegate_->EnterFullscreenModeForTab(this, origin);
 
+  RenderWidgetHostViewBase* rwhvb =

[boliu, 2017/07/05 17:39:48]

chaining these two calls through web contents does not make sense, this could be
talking to the entirely wrong render widget

RenderFrameHostImpl::OnToggleFullscreen should call things on its widget
directly using render_view_host_->GetWidget()->GetView()

+      static_cast<RenderWidgetHostViewBase*>(GetRenderWidgetHostView());
+  if (rwhvb)
+    rwhvb->OnFullscreenStateChanged();
+
   for (auto& observer : observers_)
     observer.DidToggleFullscreenModeForTab(IsFullscreenForCurrentTab(), false);
 }
 
 void WebContentsImpl::ExitFullscreenMode(bool will_cause_resize) {
   // This method is being called to leave renderer-initiated fullscreen mode.
   // Make sure any existing fullscreen widget is shut down first.
   RenderWidgetHostView* const widget_view = GetFullscreenRenderWidgetHostView();
   if (widget_view) {
     RenderWidgetHostImpl::From(widget_view->GetRenderWidgetHost())
         ->ShutdownAndDestroyWidget(true);
   }
 
 #if defined(OS_ANDROID)
   ContentVideoView* video_view = ContentVideoView::GetInstance();
   if (video_view != NULL)
     video_view->ExitFullscreen();
 #endif
 
   if (delegate_)
     delegate_->ExitFullscreenModeForTab(this);
 
+  RenderWidgetHostViewBase* rwhvb =
+      static_cast<RenderWidgetHostViewBase*>(GetRenderWidgetHostView());
+  if (rwhvb)
+    rwhvb->OnFullscreenStateChanged();
+
   // The fullscreen state is communicated to the renderer through a resize
   // message. If the change in fullscreen state doesn't cause a view resize
   // then we must ensure web contents exit the fullscreen state by explicitly
   // sending a resize message. This is required for the situation of the browser
   // moving the view into a "browser fullscreen" state and then the contents
   // entering "tab fullscreen". Exiting the contents "tab fullscreen" then won't
   // have the side effect of the view resizing, hence the explicit call here is
   // required.
   if (!will_cause_resize) {
     if (RenderWidgetHostView* rwhv = GetRenderWidgetHostView()) {
@@ skipping 3731 matching lines @@
 }
 
 void WebContentsImpl::MediaMutedStatusChanged(
     const WebContentsObserver::MediaPlayerId& id,
     bool muted) {
   for (auto& observer : observers_)
     observer.MediaMutedStatusChanged(id, muted);
 }
 
 }  // namespace content