Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: content/browser/renderer_host/fullscreen_jank_detector.h

Issue 2810813004: Hide fullscreen rotation jank (Closed)
Patch Set: Re-add feature flag Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2017 The Chromium Authors. All rights reserved.
boliu 2017/07/05 17:39:48 no (c)
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_FULLSCREEN_JANK_DETECTOR_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_FULLSCREEN_JANK_DETECTOR_H_
7
8 #include "base/macros.h"
9 #include "content/common/content_export.h"
10 #include "ui/gfx/geometry/size.h"
11
12 namespace content {
13
14 // FullscreenJankDetector receives fullscreen state and sizing changes from
15 // RenderWidgetHostViewAndroid and uses that to identify fullscreen transition
16 // frames that will look janky.
17 class CONTENT_EXPORT FullscreenJankDetector {
boliu 2017/07/05 17:39:48 I get really picky about the word "jank", because
18 public:
19 FullscreenJankDetector(){};
boliu 2017/07/05 17:39:48 space after (), and no semicolon at the end
20 ~FullscreenJankDetector(){};
21
22 void OnFullscreenStateChanged(bool is_fullscreen);
23 void OnPhysicalBackingSizeChanged(gfx::Size size);
24 void OnFrameMetadataUpdated(bool frame_is_fullscreen, gfx::Size frame_size);
25 bool IsInFullscreenTransition() const;
26
27 private:
28 enum class FullscreenState {
29 kNotFullscreen,
30 kEnteringFullscreen,
31 kFullscreen,
32 kExitingFullscreen,
33 kFullscreenRotation,
34 };
35
36 void UpdateFullscreenState();
37
38 FullscreenState state_ = FullscreenState::kNotFullscreen;
39
40 bool web_contents_is_fullscreen_ = false;
41 bool frame_is_fullscreen_ = false;
42 gfx::Size view_size_;
43 gfx::Size frame_size_;
44
45 DISALLOW_COPY_AND_ASSIGN(FullscreenJankDetector);
46 };
47
48 } // namespace content
49
50 #endif // CONTENT_BROWSER_RENDERER_HOST_FULLSCREEN_JANK_DETECTOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698